Re: RFR 8058824: Drop TwoStacks socket implementation in jdk9 [win] - Part I

2014-09-23 Thread Michael McMahon
Ivan, Okay. I see the "part 1" in the subject line now, but maybe the bug should be updated to define the scope of the change and we should file a separate bug report then. I'm okay with leaving the class with the current name. What about the datagram socket code? It might make sense to includ

Re: RFR 8058824: Drop TwoStacks socket implementation in jdk9 [win] - Part I

2014-09-23 Thread Ivan Gerasimov
Thanks Michael! On 23.09.2014 13:41, Michael McMahon wrote: Hi Ivan, Did you look at the possibility of removing the TwoStacks class altogether? For Solaris/Linux etc. ipv4 only and ipv6/v4 are all handled in the same impl class with just a switch at socket creation time, selecting AF_INET or

Re: RFR 8058824: Drop TwoStacks socket implementation in jdk9 [win] - Part I

2014-09-23 Thread Michael McMahon
Hi Ivan, Did you look at the possibility of removing the TwoStacks class altogether? For Solaris/Linux etc. ipv4 only and ipv6/v4 are all handled in the same impl class with just a switch at socket creation time, selecting AF_INET or AF_INET6. If there is a good reason to keep the implementati

RFR 8058824: Drop TwoStacks socket implementation in jdk9 [win] - Part I

2014-09-21 Thread Ivan Gerasimov
Hello! Here is a proposal for the first step in cleaning up the TwoStacks socket implementation. It is proposed to drom IPv6 support in the implementation of TwoStacksPlainSocketImpl class (so formally, it's no more Two Stacks). Therefore, this class will only be used when the user explicitly