Hi Ivan,
Did you look at the possibility of removing the TwoStacks class altogether?
For Solaris/Linux etc. ipv4 only and ipv6/v4 are all handled in the same
impl class
with just a switch at socket creation time, selecting AF_INET or AF_INET6.
If there is a good reason to keep the implementations separate then I think
the class should be renamed to reflect its new purpose.
Michael
On 21/09/14 13:19, Ivan Gerasimov wrote:
Hello!
Here is a proposal for the first step in cleaning up the TwoStacks
socket implementation.
It is proposed to drom IPv6 support in the implementation of
TwoStacksPlainSocketImpl class (so formally, it's no more Two Stacks).
Therefore, this class will only be used when the user explicitly
requests IPv4 only configuration through setting
java.net.preferIPv4Stack option.
The fix mostly consists of removal, so it should be relatively easy to
review.
All the jdk_net tests pass.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8058824
WEBREV: http://cr.openjdk.java.net/~igerasim/8058824/0/webrev/
Sincerely yours,
Ivan
