On 07/06/2019 15:16, Chris Hegarty wrote:
:
“socket implementation factory” is better. Updated:
Looks good, many inconsistencies resolved. For the CSR then the only
real change is the no-arg Socket constructor to specify existing
behavior, everything else is below the radar.
-Alan
> On 7 Jun 2019, at 15:02, Alan Bateman wrote:
>
>
>
> On 07/06/2019 14:20, Chris Hegarty wrote:
>> Alan, Daniel,
>>
>>> On 7 Jun 2019, at 13:07, Alan Bateman wrote:
>>>
>>> On 07/06/2019 12:24, Chris Hegarty wrote:
...
>>> Replacing with "plain" with system-default is okay but it do
On 07/06/2019 14:20, Chris Hegarty wrote:
Alan, Daniel,
On 7 Jun 2019, at 13:07, Alan Bateman wrote:
On 07/06/2019 12:24, Chris Hegarty wrote:
...
Replacing with "plain" with system-default is okay but it does remind me of
problems in the other constructors. The no-arg Socket constructo
On 07/06/2019 14:20, Chris Hegarty wrote:
Complete set of changes ( will be copied as-is into the CSR ):
---
LGTM Chris!
best regards,
-- daniel
Alan, Daniel,
> On 7 Jun 2019, at 13:07, Alan Bateman wrote:
>
> On 07/06/2019 12:24, Chris Hegarty wrote:
>> ...
> Replacing with "plain" with system-default is okay but it does remind me of
> problems in the other constructors. The no-arg Socket constructor is
> currently specified to use a
On 07/06/2019 12:24, Chris Hegarty wrote:
Another minor followup that we agreed to address after the integration
of 8221481 (Reimplement the Legacy Socket API).
Prior to 8221481, there was just a single default SocketImpl, the
"plain" socket impl. There are now two, PlainSocketImpl and
NioSocket
Hi Chris,
looks good to me. I just wonder if:
"Otherwise a system-default implementation is created."
would read better - but I'll defer to your judgement.
I also noticed one typo:
On 07/06/2019 12:24, Chris Hegarty wrote:
[snip]
src/java.base/share/classes/java/net/ServerSocket.java
[s
Another minor followup that we agreed to address after the integration
of 8221481 (Reimplement the Legacy Socket API).
Prior to 8221481, there was just a single default SocketImpl, the
"plain" socket impl. There are now two, PlainSocketImpl and
NioSocketImpl, the latter being the default. The fo
