On 07/06/2019 14:20, Chris Hegarty wrote:
Alan, Daniel,
On 7 Jun 2019, at 13:07, Alan Bateman <alan.bate...@oracle.com> wrote:
On 07/06/2019 12:24, Chris Hegarty wrote:
...
Replacing with "plain" with system-default is okay but it does remind me of
problems in the other constructors. The no-arg Socket constructor is currently specified
to use a system-default SocketImpl but that isn't correct when a client socket
implementation factory is set.
Good catch, I was not aware of this one. Easy to fix while here.
Added, see below.
Looks good.
In passing, the methods that set factory are specified to set the
"client socket implementation factory" or "server socket implementation
factory" but in other places they are referred to as the "client socket
factory" or "server socket factory". I don't think it matters too much
but I noticed it when looking at the diffs.
:
I’d like to address this one separately, as there are other issues
related to that specific constructor, as you have described in
8216985 [1].
Right, it's probably best to do that at around the same time as JDK-8216985.
-Alan
