Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-12-02 Thread Roger Riggs
+1 On 12/2/2017 4:17 AM, Chris Hegarty wrote: On 1 Dec 2017, at 07:13, vyom tewari wrote: Hi Chris, Thanks for review, while my testing i discovered issue in the way we handle extended socket options and standard socket options. I fixed it and updated one test as well. I removed one redun

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-12-02 Thread Chris Hegarty
> On 1 Dec 2017, at 07:13, vyom tewari wrote: > > Hi Chris, > > Thanks for review, while my testing i discovered issue in the way we handle > extended socket options and standard socket options. I fixed it and updated > one test as well. > > I removed one redundant "if check" which i think

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-12-01 Thread Roger Riggs
Hi Vyom, Looks fine Roger On 11/16/2017 4:03 AM, vyom tewari wrote: Hi All, Please review the small code change for the below issue. Webrev : http://cr.openjdk.java.net/~vtewari/8190843/webrev0.0/index.html BugId    : https://bugs.openjdk.java.net/browse/JDK-8190843 In this cod

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-30 Thread vyom tewari
Hi Chris, Thanks for review, while my testing i discovered issue in the way we handle extended  socket options and standard socket options. I fixed it and updated one test as well. I removed one redundant "if check" which i think not required. JPRT is clean with the changed code. Please fi

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-24 Thread vyom tewari
Hi Doychin, Thanks for review, i will fix it before pushing. Thanks, Vyom On Thursday 23 November 2017 03:01 PM, Doychin Bondzhev wrote: Hi Vyom, There is a typo in the comment : whis is not applicable Should be "which" On 23.11.2017 г. 11:20, vyom tewari wrote: Hi Chris, Thanks for t

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-23 Thread Chris Hegarty
> On 23 Nov 2017, at 09:20, vyom tewari wrote: > > Hi Chris, > > Thanks for the review, please find the latest > webrev(http://cr.openjdk.java.net/~vtewari/8190843/webrev0.1/index.html) > where i modified the code to take care of SO_FLOW for Solaris. I think this is fine Vyom, thanks. -Chri

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-23 Thread Doychin Bondzhev
Hi Vyom, There is a typo in the comment : whis is not applicable Should be "which" On 23.11.2017 г. 11:20, vyom tewari wrote: Hi Chris, Thanks for the review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8190843/webrev0.1/index.html) where i modified the code to take

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-23 Thread vyom tewari
Hi Chris, Thanks for the review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8190843/webrev0.1/index.html) where i modified the code to take care of SO_FLOW for Solaris. I updated the test code as well. Thanks, Vyom On Monday 20 November 2017 08:50 PM, Chris Hegarty

Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-20 Thread Chris Hegarty
Vyom, On 16/11/17 09:03, vyom tewari wrote: Hi All, Please review the small code change for the below issue. Webrev : http://cr.openjdk.java.net/~vtewari/8190843/webrev0.0/index.html BugId: https://bugs.openjdk.java.net/browse/JDK-8190843 In this code change, i removed the chec

RFR:8190843 can not set/get extendedOptions to ServerSocket

2017-11-16 Thread vyom tewari
Hi All, Please review the small code change for the below issue. Webrev : http://cr.openjdk.java.net/~vtewari/8190843/webrev0.0/index.html BugId    : https://bugs.openjdk.java.net/browse/JDK-8190843 In this code change, i removed the check(getSocket() == null) which will always be t