Re: RFR:8190843 can not set/get extendedOptions to ServerSocket

[Doychin Bondzhev]

Hi Vyom,

There is a typo in the comment :

whis is not applicable

Should be "which"


On 23.11.2017 г. 11:20, vyom tewari wrote:

Hi Chris,

Thanks for the review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8190843/webrev0.1/index.html) where i modified the code to take care of SO_FLOW for Solaris.

I updated the test code as well.

Thanks,

Vyom


On Monday 20 November 2017 08:50 PM, Chris Hegarty wrote:

Vyom,

On 16/11/17 09:03, vyom tewari wrote:

Hi All,

Please review the small code change for the below issue.

Webrev     : http://cr.openjdk.java.net/~vtewari/8190843/webrev0.0/index.html

BugId        : https://bugs.openjdk.java.net/browse/JDK-8190843

In this code change, i removed the check(getSocket() == null) which will always be true for ServerSocket as in case of server socket we set "serverSocket" not "socket".

I think that this change is good. What will happen if SO_FLOW is set
on a ServerSocket?

-Chris.

--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
PowerStor - Warehouse & POS
http://www.dsoft-bg.com/
Mobile: +359888243116

<<attachment: doychin.vcf>>

smime.p7s
Description: S/MIME Cryptographic Signature