Re: RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-21 Thread Chris Hegarty
On 21/11/18 09:38, vyom tewari wrote: Hi Chris, thanks for review, you are right, we should clear the pending exception if -2 is return. Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.2/index.html). Thank you. I think this is good. -Chris.

Re: RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-21 Thread vyom tewari
Hi Chris, thanks for review, you are right, we should clear the pending exception if -2 is return. Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.2/index.html). Thanks, Vyom On 15/11/18 9:57 PM, Chris Hegarty wrote: Vyom, On 13 Nov 2018, at 12:35, vyom

Re: RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-15 Thread Chris Hegarty
Vyom, > On 13 Nov 2018, at 12:35, vyom tewari wrote: > > Hi Chris, > > Thanks for review, please find the latest > webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html) > where i incorporated your suggestion. Now i am returning the different error > code(-2) if IP Helper L

Re: RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-13 Thread vyom tewari
reseeding again,  looks like some problem with my email client. Vyom On 13/11/18 6:05 PM, vyom tewari wrote: Hi Chris, Thanks for review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html) where i incorporated your suggestion. Now i am returning t

Re: RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-13 Thread vyom tewari
Hi Chris, Thanks for review, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html) where i incorporated your suggestion. Now i am returning the different error code(-2) if IP Helper Library function GetIfTable fails. I checked the all other call sites

Re: RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-08 Thread Chris Hegarty
Hi Vyom, On 08/11/18 09:22, vyom tewari wrote: Hi, Please review the below code change. Webrev: http://cr.openjdk.java.net/~vtewari/8046500/webrev0.0/index.html enumInterfaces may return -1 for error conditions other than IP Helper Library GetIfTable function failed. I wonder if this specifi

RFR:8046500 GetIpAddrTable function failed on Pure Ipv6 environment

2018-11-08 Thread vyom tewari
Hi, Please review the below code change. Webrev: http://cr.openjdk.java.net/~vtewari/8046500/webrev0.0/index.html BugId:  https://bugs.openjdk.java.net/browse/JDK-8046500 This issue is specific to pure ipv6 environment, In pure ipv6 environment  if "enumInterface" fails,  i am clearing th