Vyom, > On 13 Nov 2018, at 12:35, vyom tewari <vyom.tew...@oracle.com> wrote: > > Hi Chris, > > Thanks for review, please find the latest > webrev(http://cr.openjdk.java.net/~vtewari/8046500/webrev0.1/index.html) > where i incorporated your suggestion. Now i am returning the different error > code(-2) if IP Helper Library function GetIfTable fails. I checked the all > other call sites and we don't need to do any additional changes.
This looks much better to me. One question … Looking at `createNetworkInterfaceXP` I wonder if its usage of `enumAddresses_win` should clear the pending exception if -2 is returned? -Chris.
