Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-21 Thread Michael McMahon
On Wed, 21 Oct 2020 09:20:47 GMT, Chris Hegarty wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> further test update from Daniel > > test/jdk/java/net/UnixDomainSocketAddress/LengthTest.java line 55: > >> 53:

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-21 Thread Chris Hegarty
On Tue, 20 Oct 2020 14:21:42 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-20 Thread Daniel Fuchs
On Tue, 20 Oct 2020 14:21:42 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-20 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use