Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Michael McMahon
On Tue, 20 Oct 2020 10:36:24 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> final feedback from Alan > > test/jdk/java/nio/channels/unixdomain/SocketOptions.java line 59: > >> 57: s.b

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Michael McMahon
On Tue, 20 Oct 2020 10:28:13 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> final feedback from Alan > > test/jdk/java/nio/channels/unixdomain/NonBlockingAccept.java line 61: > >> 59:

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Daniel Fuchs
On Mon, 19 Oct 2020 22:13:40 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Alan Bateman
On Mon, 19 Oct 2020 22:13:40 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-19 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use