On Tue, 20 Oct 2020 10:28:13 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   final feedback from Alan
>
> test/jdk/java/nio/channels/unixdomain/NonBlockingAccept.java line 61:
> 
>> 59:             System.out.println("The socketChannel is : expected Null " + 
>> socketChannel);
>> 60:             // exception could be thrown otherwise
>> 61:         }
> 
> Do we have/need a test that goes the whole way down? Register for OP_CONNECT 
> with a selector and wait for the connect
> to finish?

Yes, the IOExchanges test covers many different scenarios around that

-------------

PR: https://git.openjdk.java.net/jdk/pull/52

Reply via email to