Re: RFR: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient

2019-09-09 Thread Chris Hegarty
> On 9 Sep 2019, at 17:37, Daniel Fuchs wrote: > > Thanks Chris. > > All good comments. > > new webrev at: > http://cr.openjdk.java.net/~dfuchs/webrev_8230526/webrev.01/ LGTM. > I'm not sure all httpclient tests that use jdk.httpserver have the > appropriate @module tag. But that should be

Re: RFR: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient

2019-09-09 Thread Daniel Fuchs
Thanks Chris. All good comments. new webrev at: http://cr.openjdk.java.net/~dfuchs/webrev_8230526/webrev.01/ I'm not sure all httpclient tests that use jdk.httpserver have the appropriate @module tag. But that should be for some further cleanup. best regards, -- daniel On 09/09/2019 16:35, C

Re: RFR: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient

2019-09-09 Thread Chris Hegarty
Daniel, > On 6 Sep 2019, at 14:27, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for: > 8230526: jdk.internal.net.http.PlainProxyConnection is never reused > by HttpClient > https://bugs.openjdk.java.net/browse/JDK-8230526 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webr

RFR: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient

2019-09-06 Thread Daniel Fuchs
Hi, Please find below a fix for: 8230526: jdk.internal.net.http.PlainProxyConnection is never reused by HttpClient https://bugs.openjdk.java.net/browse/JDK-8230526 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8230526/webrev.00/ Indeed, the new HttpClient never reuses plain proxy c