Daniel, > On 6 Sep 2019, at 14:27, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi, > > Please find below a fix for: > 8230526: jdk.internal.net.http.PlainProxyConnection is never reused > by HttpClient > https://bugs.openjdk.java.net/browse/JDK-8230526 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webrev_8230526/webrev.00/
The source changes look good. A few small comments on the test: 1) @modules java.net.http This should be jdk.httpserver, right? - since there is a TEST.properties that already specifies the java.net.http module. 2) Maybe refactor some of the initial code in the `test` method into, say, `sanity`? as it is not really testing the bug, but the test itself, right? 3) Trivially, I don’t think that the @library is needed? 4) Maybe reword the comment on the `createHttpsServer` test method, “For convenience the server is used as ...”. -Chris.
