On 18/07/2019 15:43, Patrick Concannon wrote:
Oh OK, I didn't realise. Thanks for pointing this out, Alan!
I've removed the 'othervm' tag, and added it to the new webrev below.
http://cr.openjdk.java.net/~aefimov/pconcann/8227721/01/
This looks good to me.
-Alan
Oh OK, I didn't realise. Thanks for pointing this out, Alan!
I've removed the 'othervm' tag, and added it to the new webrev below.
http://cr.openjdk.java.net/~aefimov/pconcann/8227721/01/
Kind regards,
Patrick
On 18/07/2019 08:53, Alan Bateman wrote:
On 17/07/2019 17:52, Patrick Concannon wr
On 17/07/2019 17:52, Patrick Concannon wrote:
:
This fix sets the test to run in 'othervm' mode, and gives 'open'
access to 'java.net' to the unnamed module (where the test lives).
I don't think you need to run the test in /othervm mode as jtreg will
look after spinning up a new agent VM whe
> On 17 Jul 2019, at 17:52, Patrick Concannon
> wrote:
>
> ...
> Webrev for fix: http://cr.openjdk.java.net/~aefimov/pconcann/8227721/00/
Looks good Patrick. Reviewed.
-Chris.
Hi Patrick,
Based on [1] this looks OK to me.
Brian
[1] https://openjdk.java.net/jtreg/tag-spec.html
> On Jul 17, 2019, at 9:52 AM, Patrick Concannon
> wrote:
>
> Would it be possible to have my fix for JDK-8227721 reviewed?
>
> test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTe
Hi,
Would it be possible to have my fix for JDK-8227721 reviewed?
test/jdk/java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java
has been recently modified to perform a deep reflection (
setAccessible(true) ) on a non-public member
java.net.NetworkInterface::isBoundInetAddress. Howeve
