Thank you Daniel.
-Jaikiran
On 03/09/19 10:20 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> Tests were successful and I pushed it...
>
> best regards,
>
> -- daniel
>
> On 02/09/2019 12:29, Daniel Fuchs wrote:
>> On 02/09/2019 12:23, Jaikiran Pai wrote:
>>> This does look better. I have updated the
Hi Jaikiran,
Tests were successful and I pushed it...
best regards,
-- daniel
On 02/09/2019 12:29, Daniel Fuchs wrote:
On 02/09/2019 12:23, Jaikiran Pai wrote:
This does look better. I have updated the code to use this construct and
the new webrev is at
http://cr.openjdk.java.net/~jpai/webre
Thanks for the update Jaikiran!
This looks good to me. I will import it in my repo and test it
for a while...
best regards,
-- daniel
On 02/09/2019 12:23, Jaikiran Pai wrote:
This does look better. I have updated the code to use this construct and
the new webrev is at
http://cr.openjdk.java.n
Hello Vyom, Daniel,
On 02/09/19 3:00 PM, Daniel Fuchs wrote:
> Hi,
>
> On 02/09/2019 05:29, Vyom Tewari26 wrote:
>>> 2-> i think super.stop() should be the first line in the
>>> overridden stop method.
>>
>> I had thought of this when I introduced the change. However, I felt
>> tha
Hi,
On 02/09/2019 05:29, Vyom Tewari26 wrote:
2-> i think super.stop() should be the first line in the
overridden stop method.
I had thought of this when I introduced the change. However, I felt
that it's better to set the stop=true before calling the
super.stop(), since th
Hi Jaikiran,
Please find my comments inline.
- Original message -From: Jaikiran Pai To: Vyom Tewari26 Cc: daniel.fu...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR: 8223714: HTTPSetAuthenticatorTest could be made more resilientDate: Mon, Sep 2, 2019 9:21 AM
Hello Vyo
On 02/09/19 9:21 AM, Jaikiran Pai wrote:
>
> Hello Vyom,
>
> Thank you for the review. Comments inline.
>
> On 31/08/19 7:05 PM, Vyom Tewari26 wrote:
>> Hi Jaikiran,
>>
>> Code changes look OK to me , couple of minor comments
>> 1-> you don't need "this" to access stop(this.stop)
>
> Usage of th
Hello Vyom,
Thank you for the review. Comments inline.
On 31/08/19 7:05 PM, Vyom Tewari26 wrote:
> Hi Jaikiran,
>
> Code changes look OK to me , couple of minor comments
> 1-> you don't need "this" to access stop(this.stop)
Usage of this.member, is more of a personal practice that I try to
fol
Hi Jaikiran,
Code changes look OK to me , couple of minor comments
1-> you don't need "this" to access stop(this.stop)
2-> i think super.stop() should be the first line in the overridden stop
method.
3-> it is matter of personal preference but my preference is use the new
variable name 'running' t
Hi Jaikiran,
Code changes look OK to me , couple of minor comments
1-> you don't need "this" to access stop(this.stop)
2-> i think super.stop() should be the first line in the overridden stop method.
3-> it is matter of personal preference but my preference is use the new variable name 'running'
Hello Daniel,
On 30/08/19 9:14 PM, Daniel Fuchs wrote:
> Hi Jaikiran,
>
> 1075 System.out.println("Server will stop
> accepting connections due to an exception");
> 1076 io.printStackTrace(System.out);
> 1077 break;
>
> Two things here:
>
Hi Jaikiran,
1075 System.out.println("Server will stop accepting
connections due to an exception");
1076 io.printStackTrace(System.out);
1077 break;
Two things here:
1.if ss.connect() throws, it may be because ss is closed, or not.
On 30/08/19 5:40 PM, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a patch for
> https://bugs.openjdk.java.net/browse/JDK-8223714?
>
> The patch is available as a webrev at
> http://cr.openjdk.java.net/~jpai/webrev/8223714/1/webrev/
>
> This issue and the patch relates solely
Can I please get a review and a sponsor for a patch for
https://bugs.openjdk.java.net/browse/JDK-8223714?
The patch is available as a webrev at
http://cr.openjdk.java.net/~jpai/webrev/8223714/1/webrev/
This issue and the patch relates solely to a test infrastructure class -
HTTPTestServer and tou
14 matches
Mail list logo
