On 02/09/19 9:21 AM, Jaikiran Pai wrote: > > Hello Vyom, > > Thank you for the review. Comments inline. > > On 31/08/19 7:05 PM, Vyom Tewari26 wrote: >> Hi Jaikiran, >> >> Code changes look OK to me , couple of minor comments >> 1-> you don't need "this" to access stop(this.stop) > > Usage of this.member, is more of a personal practice that I try to > follow whenever possible, to avoid accidental shadowing of local > variables. Seeing the rest of the code (even one of my own reference > to stop where I didn't use this.stop), I think it makes it consistent > not to use this.stop. So I have gone ahead and updated the webrev (at > the same location[1]) to change this.stop to stop. > Forgot the link to the webrev. It's here http://cr.openjdk.java.net/~jpai/webrev/8223714/2/webrev/
-Jaikiran
