Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-15 Thread Mark Sheppard
Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi Alex, Mark, While I think that change for this issue is good, I would like to request that we please put it on hold temporarily. I will experiment with possible solutions for 8246714 - the

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-15 Thread Chris Hegarty
c: Mark Sheppard > Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when > file is not found > > Hi, > > CSR: https://bugs.openjdk.java.net/browse/JDK-8244650 > <https://bugs.openjdk.java.net/browse/JDK-8244650> > > On 06/13/2020 10:49 PM, mark sheppard wro

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-15 Thread mark sheppard
Network Dev list Cc: Mark Sheppard Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi, CSR: https://bugs.openjdk.java.net/browse/JDK-8244650 On 06/13/2020 10:49 PM, mark sheppard wrote: > Hi, > For JDK-8132359 it now addresses the

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-15 Thread Alex Kashchenko
Hi, CSR: https://bugs.openjdk.java.net/browse/JDK-8244650 On 06/13/2020 10:49 PM, mark sheppard wrote: Hi, For JDK-8132359 it now addresses the issue: Amend JarURLConnection::getJarFile() to return JarFile object reference for nonexistent JAR file entry URL The scenario addressed is that

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-13 Thread mark sheppard
appear that there is merit in this fix. regards Mark From: net-dev on behalf of Alex Kashchenko Sent: Wednesday 10 June 2020 14:52 To: OpenJDK Network Dev list Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-10 Thread Alex Kashchenko
On 06/10/2020 03:52 PM, Alex Kashchenko wrote: Hi, On 05/12/2020 12:20 AM, Alex Kashchenko wrote: CSR: https://bugs.openjdk.java.net/browse/JDK-8244650 A question about this CSR: after this new issue was found in the same area: JDK-8246714: URLClassLoader/JAR protocol handler poisons the glo

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-06-10 Thread Alex Kashchenko
Hi, On 05/12/2020 12:20 AM, Alex Kashchenko wrote: CSR: https://bugs.openjdk.java.net/browse/JDK-8244650 A question about this CSR: after this new issue was found in the same area: JDK-8246714: URLClassLoader/JAR protocol handler poisons the global JarFile cache under concurrent load would

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-11 Thread Michael McMahon
On 10/05/2020 21:51, Alex Kashchenko wrote: Thanks for your comments! On 05/08/2020 06:38 PM, Michael McMahon wrote: [...] https://bugs.openjdk.java.net/browse/JDK-8244650 I believe some sort of spec change will be needed, if only to justify challenging the JCK. Currently, the proposed c

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-10 Thread Alex Kashchenko
Thanks for your comments! On 05/08/2020 06:38 PM, Michael McMahon wrote: [...] https://bugs.openjdk.java.net/browse/JDK-8244650 I believe some sort of spec change will be needed, if only to justify challenging the JCK. Currently, the proposed change trips the following test: TestCase: [Jar

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-08 Thread Michael McMahon
On 08/05/2020 17:34, Daniel Fuchs wrote: Hi Alex, On 08/05/2020 15:35, Alex Kashchenko wrote: On 05/06/2020 01:11 PM, Michael McMahon wrote: Hi, Yes, we've had some discussion about it internally, and while others may yet have an opinion, I think this approach is a reasonable one, with a

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-08 Thread Daniel Fuchs
Hi Alex, On 08/05/2020 15:35, Alex Kashchenko wrote: On 05/06/2020 01:11 PM, Michael McMahon wrote: Hi, Yes, we've had some discussion about it internally, and while others may yet have an opinion, I think this approach is a reasonable one, with a spec change that captures the behavior. I'

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-08 Thread Alex Kashchenko
On 05/06/2020 01:11 PM, Michael McMahon wrote: Hi, Yes, we've had some discussion about it internally, and while others may yet have an opinion, I think this approach is a reasonable one, with a spec change that captures the behavior. The main thing we need to capture is that while connect()

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-06 Thread Michael McMahon
om: net-dev on behalf of mark sheppard Sent: Wednesday 1 April 2020 16:03 To: Michael McMahon ; Alex Kashchenko Cc: Mark Sheppard ; net-dev@openjdk.java.net >> OpenJDK Network Dev list Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-01 Thread Alex Kashchenko
Sent: Wednesday 1 April 2020 16:03 To: Michael McMahon ; Alex Kashchenko Cc: Mark Sheppard ; net-dev@openjdk.java.net >> OpenJDK Network Dev list Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi Michael et al., just looking

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-04-01 Thread mark sheppard
; net-dev@openjdk.java.net >> OpenJDK Network Dev list Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi Michael et al., just looking at the webrev ... the change in URLClassPath seems reasonable. The change in JarURLConnection has implic

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-04-01 Thread mark sheppard
2:39 To: Alex Kashchenko Cc: net-dev@openjdk.java.net >> OpenJDK Network Dev list Subject: Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found Hi Alex, (and redirecting the thread to net-dev) It looks like a straight forward solution and perhaps the compatibili

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-03-16 Thread Michael McMahon
Hi Alex, (and redirecting the thread to net-dev) It looks like a straight forward solution and perhaps the compatibility test could be challenged on the basis of reliance on implementation behavior rather than the spec. But, more important I think is the behavior change of the fix itself and