RE: RFR: 8170544: Fix code scan findings in libnet

2017-01-13 Thread Langer, Christoph
- > d...@openjdk.java.net; Michael McMahon > Subject: RE: RFR: 8170544: Fix code scan findings in libnet > > Hi Chris, > > thanks for looking. > > > 1) NetworkInterface.c > > > > I’m not sure that the close is really necessary, since a JNI pending > >

RE: RFR: 8170544: Fix code scan findings in libnet

2017-01-11 Thread Langer, Christoph
Hi Chris, thanks for looking. > 1) NetworkInterface.c > > I’m not sure that the close is really necessary, since a JNI pending > exception can only be thrown is sock is less than 0. I think just > removing the ' && (*env)->ExceptionOccurred(env)’ from the original > if statement

Re: RFR: 8170544: Fix code scan findings in libnet

2017-01-03 Thread Chris Hegarty
> On 29 Dec 2016, at 13:20, Langer, Christoph wrote: > > Hi Goetz, > > thanks for reviewing this. > > I have addressed your comments in a new webrev: > http://cr.openjdk.java.net/~clanger/webrevs/8170544.1/ This mainly looks fine. Just a few comments: 1) NetworkInterface.c I’m not sure

RE: RFR: 8170544: Fix code scan findings in libnet

2016-12-29 Thread Lindenmaier, Goetz
> Subject: RE: RFR: 8170544: Fix code scan findings in libnet > > Hi Goetz, > > thanks for reviewing this. > > I have addressed your comments in a new webrev: > http://cr.openjdk.java.net/~clanger/webrevs/8170544.1/ > > Here's the details: > > > > ht

RE: RFR: 8170544: Fix code scan findings in libnet

2016-12-29 Thread Langer, Christoph
Hi Goetz, thanks for reviewing this. I have addressed your comments in a new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.1/ Here's the details: > http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/src/java.base/share/na > tive/libnet/net_util.c.udiff.html > + * check now

RE: RFR: 8170544: Fix code scan findings in libnet

2016-12-29 Thread Lindenmaier, Goetz
To: Michael McMahon > Cc: net-dev@openjdk.java.net; Chris Hegarty ; > Lindenmaier, Goetz > Subject: RE: RFR: 8170544: Fix code scan findings in libnet > > Hi Michael, > > > > I have just updated http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/ in > place. The old

Re: RFR: 8170544: Fix code scan findings in libnet

2016-12-01 Thread Michael McMahon
on caused a compile warning on Linux. Best regards Christoph *From:*Langer, Christoph *Sent:* Mittwoch, 30. November 2016 19:01 *To:* 'Michael McMahon' *Cc:* net-dev@openjdk.java.net; Chris Hegarty ; Lindenmaier, Goetz *Subject:* RE: RFR: 8170544: Fix code scan findings in libnet Th

RE: RFR: 8170544: Fix code scan findings in libnet

2016-12-01 Thread Langer, Christoph
net; Chris Hegarty ; Lindenmaier, Goetz Subject: RE: RFR: 8170544: Fix code scan findings in libnet Thanks, Michael. Maybe you can run all the 3 together: http://cr.openjdk.java.net/~clanger/webrevs/8167457.1/ http://cr.openjdk.java.net/~clanger/webrevs/8167420.2/ http://cr.openjdk.java.ne

RE: RFR: 8170544: Fix code scan findings in libnet

2016-11-30 Thread Langer, Christoph
gards Christoph From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] Sent: Mittwoch, 30. November 2016 17:57 To: Langer, Christoph Cc: net-dev@openjdk.java.net; Chris Hegarty ; Lindenmaier, Goetz Subject: Re: RFR: 8170544: Fix code scan findings in libnet I will run the change through

Re: RFR: 8170544: Fix code scan findings in libnet

2016-11-30 Thread Michael McMahon
I will run the change through JPRT Christoph Thanks Michael On 30/11/2016, 16:32, Langer, Christoph wrote: Hi, please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8170544 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8170544.0/