RE: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

2020-03-24 Thread Langer, Christoph
Hi Alex, looks good now. Cheers Christoph > -Original Message- > From: Alex Kashchenko > Sent: Dienstag, 24. März 2020 19:09 > To: Langer, Christoph ; jdk-updates- > d...@openjdk.java.net > Cc: net-dev@openjdk.java.net > Subject: Re: [11u] RFR: 8183369

Re: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

2020-03-24 Thread Alex Kashchenko
Hi Christoph, On 03/24/2020 12:36 PM, Langer, Christoph wrote: Hi Alex, I think this looks good overall. Thanks for the review! There's one line in test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java, line 85, where you got the indentation wrong. Please check and fix that. Sor

RE: [11u] RFR: 8183369: RFC unconformity of HttpURLConnection with proxy

2020-03-24 Thread Langer, Christoph
Hi Alex, I think this looks good overall. There's one line in test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java, line 85, where you got the indentation wrong. Please check and fix that. Best regards Christoph > -Original Message- > From: jdk-updates-dev On > Behalf Of Alex