Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Alan Bateman wrote: . I'm tempted to suggest that the best thing is to just hg rm the test as it's not very useful. If you want to keep it then the changes looks OK This had crossed my mind. If you agree then I think I will just rem

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Christopher Hegarty -Sun Microsystems Ireland
Alan Bateman wrote: . I'm tempted to suggest that the best thing is to just hg rm the test as it's not very useful. If you want to keep it then the changes looks OK This had crossed my mind. If you agree then I think I will just remove it. -Chris. to me. One suggestion is to have ARea

Re: Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: Hi Alan, Michael, Another small test change! This test requires interruptible I/O to verify that the accept implementation does not impact on fd0. UseVMInterruptibleIO needs to be explicitly enabled since it is now disabled by default, see

Code Review 6934054: java/net/Socket/FDClose.java return error in samevm

2010-03-11 Thread Christopher Hegarty -Sun Microsystems Ireland
Hi Alan, Michael, Another small test change! This test requires interruptible I/O to verify that the accept implementation does not impact on fd0. UseVMInterruptibleIO needs to be explicitly enabled since it is now disabled by default, see 6554406. Without interruptible I/O the thread executi