Re: 8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

2018-10-31 Thread Chris Hegarty
> On 31 Oct 2018, at 19:26, Brian Burkhalter > wrote: > > ... > > --- a/src/java.base/share/classes/java/net/ServerSocket.java > +++ b/src/java.base/share/classes/java/net/ServerSocket.java > @@ -76,10 +76,16 @@ > private boolean oldImpl = false; > > /** > - * Package-private

Re: 8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

2018-10-31 Thread Alan Bateman
On 31/10/2018 19:26, Brian Burkhalter wrote: On Oct 31, 2018, at 12:20 PM, Brian Burkhalter mailto:brian.burkhal...@oracle.com>> wrote: -   ServerSocket(SocketImpl impl) { +   protected ServerSocket(SocketImpl impl) {       this.impl = impl;       impl.setServerSocket(this); // <- NPE if impl

Re: 8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

2018-10-31 Thread Brian Burkhalter
> On Oct 31, 2018, at 12:20 PM, Brian Burkhalter > wrote: > > -ServerSocket(SocketImpl impl) { > +protected ServerSocket(SocketImpl impl) { > this.impl = impl; > impl.setServerSocket(this); // <- NPE if impl == null > } Oops, it can throw null as indicated above.

Re: 8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

2018-10-31 Thread Brian Burkhalter
> On Oct 31, 2018, at 12:16 PM, Alan Bateman wrote: > > On 31/10/2018 19:13, Brian Burkhalter wrote: >> https://bugs.openjdk.java.net/browse/JDK-8213210 >> >> >> Please see diff included below. CSR to follow. > One thing to check is whether Se

Re: 8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

2018-10-31 Thread Alan Bateman
On 31/10/2018 19:13, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8213210 Please see diff included below. CSR to follow. One thing to check is whether ServerSocket specifies null handling anywhere. I don't think it does so you might have to add an @throws NPE. -Alan

8213210: Change ServerSocket(SocketImpl impl) constructor to protected access

2018-10-31 Thread Brian Burkhalter
https://bugs.openjdk.java.net/browse/JDK-8213210 Please see diff included below. CSR to follow. Thanks, Brian --- a/src/java.base/share/classes/java/net/ServerSocket.java +++ b/src/java.base/share/classes/java/net/ServerSocket.java @@ -76,10 +76,13 @@ private boolean oldImpl = false;