> On 31 Oct 2018, at 19:26, Brian Burkhalter <brian.burkhal...@oracle.com>
> wrote:
>
> ...
>
> --- a/src/java.base/share/classes/java/net/ServerSocket.java
> +++ b/src/java.base/share/classes/java/net/ServerSocket.java
> @@ -76,10 +76,16 @@
> private boolean oldImpl = false;
>
> /**
> - * Package-private constructor to create a ServerSocket associated with
> - * the given SocketImpl.
> + * Creates a server socket with a user-specified {@code SocketImpl}.
> + *
> + * @param impl an instance of a SocketImpl the subclass
> + * wishes to use on the ServerSocket.
> + *
> + * @throws NullPointerException if impl is {@code null}
> + *
> + * @since 12
> */
> - ServerSocket(SocketImpl impl) {
> + protected ServerSocket(SocketImpl impl) {
> this.impl = impl;
> impl.setServerSocket(this);
> }
I think this is good. I added myself as reviewer on the CSR too.
-Chris.
