Re: [RFR]: 8223652: Rename IPSupport.skipIfCurrentConfigurationIsInvalid()

2019-05-10 Thread Chris Hegarty
+1 -Chris On 09/05/2019 18:52, Daniel Fuchs wrote: Hi Arthur, Looks good to me. best regards, -- daniel On 09/05/2019 18:40, Arthur Eubanks wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223652 Webrev: http://cr.openjdk.java.net/~aeubanks/8223652/webrev.00/index.html As mentioned i

Re: [RFR]: 8223652: Rename IPSupport.skipIfCurrentConfigurationIsInvalid()

2019-05-09 Thread Daniel Fuchs
Hi Arthur, Looks good to me. best regards, -- daniel On 09/05/2019 18:40, Arthur Eubanks wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223652 Webrev: http://cr.openjdk.java.net/~aeubanks/8223652/webrev.00/index.html As mentioned in https://markmail.org/search/?q=aeubanks%40google.co