+1

-Chris

On 09/05/2019 18:52, Daniel Fuchs wrote:
Hi Arthur,

Looks good to me.

best regards,

-- daniel

On 09/05/2019 18:40, Arthur Eubanks wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223652
Webrev: http://cr.openjdk.java.net/~aeubanks/8223652/webrev.00/index.html

As mentioned in https://markmail.org/search/?q=aeubanks%40google.com#query:aeubanks%40google.com+page:1+mid:rjthqgdeghv6vyck+state:results, IPSupport.skipIfCurrentConfigurationIsInvalid() is ambiguous (how is it skipping the test? what is a configuration?)

Something like IPSupport.throwSkippedExceptionIfNonOperational() is probably better.

Reply via email to