OK, after checking with the Solaris folks on the possibility of removing
the workaround ( that contains the isspace check ), it looks like they
cannot confirm that it has indeed been fixed. With that in mind I
decided to keep it and only include it for Solaris builds.
Please take a look at the
On Feb 2, 1:42pm, christopher.hega...@sun.com (Christopher Hegarty - Sun
Microsystems Ireland) wrote:
-- Subject: Re: [Fwd: [PATCH]: Portability fixes]
| Hi Alan, Christos,
|
| I've looked at the changes that Christos suggested and also how Martin
| fixed UNIXProcess_md. Here is w
Martin Buchholz wrote:
On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems
Ireland wrote:
+static int isAsciiSpace(char c) {
+ return (((c) == '\t') || ((c) == '\r') || ((c) == '\b') ||
+ ((c) == '\n') || ((c) == ' ') );
+}
+
A very minor comment -
the parens aroun
On Mon, Feb 2, 2009 at 05:42, Christopher Hegarty - Sun Microsystems
Ireland wrote:
> +static int isAsciiSpace(char c) {
> + return (((c) == '\t') || ((c) == '\r') || ((c) == '\b') ||
> + ((c) == '\n') || ((c) == ' ') );
> +}
> +
A very minor comment -
the parens around (c) are a very
Christopher Hegarty - Sun Microsystems Ireland wrote:
Hi Alan, Christos,
I've looked at the changes that Christos suggested and also how Martin
fixed UNIXProcess_md. Here is what I believe the final change should
look like.
Comments:
1) "3. last is possibly uninitialized."
We have already
Hi Alan, Christos,
I've looked at the changes that Christos suggested and also how Martin
fixed UNIXProcess_md. Here is what I believe the final change should
look like.
Comments:
1) "3. last is possibly uninitialized."
We have already fixed this in a previous changeset, see [1]
2) I made
Hi Alan,
Yes, I will assign 6799040 to myself and work with Christos to finalize
the networking changes.
Thanks,
-Chris.
Alan Bateman wrote:
Christos mailed core-libs-dev yesterday with a few portability
issues.Anyone have cycles to look at the Inet4AddressImpl.c changes?
I've created 67990
Christos mailed core-libs-dev yesterday with a few portability
issues.Anyone have cycles to look at the Inet4AddressImpl.c changes?
I've created 6799040 to track it. Martin has already pushed a changeset
to jdk7/tl/jdk for the UNIXProcess_md.c issue.
--- Begin Message ---
Hello,
Here are some s
