Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-12 Thread Chris Hegarty
On 12/10/18 03:46, Chris Yin wrote: ... Thanks for your suggestion, currently, I just added a comment to explain the 220 response message and sent updated webrev in earlier thread, I may prefer to process in that way for now if no objection since separate specific test added for 8151586 is

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-11 Thread Chris Yin
Hi, Vyom, Chris H. > On 11 Oct 2018, at 7:08 PM, Chris Hegarty wrote: > > > >> On 11 Oct 2018, at 12:02, vyom tewari > > wrote: >> On Thursday 11 October 2018 02:15 PM, Chris Yin wrote: >>> Please review below small change to fix test >>> sun/net/ftp/FtpURLConne

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-11 Thread Chris Yin
Hi, Chris H. Thanks for your review and comments, I just added a comment as you suggested and update new webrev as below, please have a review. http://cr.openjdk.java.net/~xyin/8187522/webrev.01/ Thanks, Chris Y. > On 11 Oct 2018, at 7:00 PM, Chris Hegarty wrote: > > Chris Y, > >> On 11 Oct

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-11 Thread Chris Hegarty
> On 11 Oct 2018, at 12:02, vyom tewari wrote: > On Thursday 11 October 2018 02:15 PM, Chris Yin wrote: >> Please review below small change to fix test >> sun/net/ftp/FtpURLConnectionLeak.Java, thanks >> >> Besides the original timeout issue, looks like the test not working as >> expected eve

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-11 Thread vyom tewari
On Thursday 11 October 2018 02:15 PM, Chris Yin wrote: Please review below small change to fix test sun/net/ftp/FtpURLConnectionLeak.Java, thanks Besides the original timeout issue, looks like the test not working as expected even the results is pass. Per test description, we expect FileNot

Re: [12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-11 Thread Chris Hegarty
Chris Y, > On 11 Oct 2018, at 09:45, Chris Yin wrote: > > Please review below small change to fix test > sun/net/ftp/FtpURLConnectionLeak.Java, thanks > > Besides the original timeout issue, looks like the test not working as > expected even the results is pass. Per test description, we expec

[12] RFR 8187522: sun/net/ftp/FtpURLConnectionLeak.Java timed out

2018-10-11 Thread Chris Yin
Please review below small change to fix test sun/net/ftp/FtpURLConnectionLeak.Java, thanks Besides the original timeout issue, looks like the test not working as expected even the results is pass. Per test description, we expect FileNotFoundException and then verify connection closed, but look