Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2012-08-28 Thread Shirish Kuncolienkar
On 8/24/2012 9:32 PM, Shirish Kuncolienkar wrote: On 8/24/2012 5:39 PM, Michael McMahon wrote: On 23/08/12 18:50, Shirish Kuncolienkar wrote: Could I get the change reviewed please This behavior is seen on Windows. Logic in URLClassPath.getLoader() does not take care of an URL which looks

Re: Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2012-08-24 Thread Shirish Kuncolienkar
On 8/24/2012 5:39 PM, Michael McMahon wrote: On 23/08/12 18:50, Shirish Kuncolienkar wrote: Could I get the change reviewed please This behavior is seen on Windows. Logic in URLClassPath.getLoader() does not take care of an URL which looks like "jar:file:/C:/test/xyz.jar!/". The log

Code review request 7183373: URLClassloader.close() does not close JAR files whose resources have been loaded via getResource()

2012-08-23 Thread Shirish Kuncolienkar
Could I get the change reviewed please This behavior is seen on Windows. Logic in URLClassPath.getLoader() does not take care of an URL which looks like "jar:file:/C:/test/xyz.jar!/". The logic ends up choosing a FileLoader instead of a JarLoader. JarLoader has provision for closing file hand

Parsing of URL's which contain Windows Path separator

2012-08-20 Thread Shirish Kuncolienkar
Any thoughts on the following It will be good if the one could create relative url from other url which is based on windows style path. example "hello.html" relative "http://someserver/foo/bar"; becomes "http://someserver/foo/hello.html"; In the similar way "hello.html"relative to "file:///C:

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-13 Thread Shirish Kuncolienkar
Thank you Chris -Shirish On 8/13/2012 6:24 PM, Chris Hegarty wrote: On 13/08/2012 13:36, Shirish Kuncolienkar wrote: Chris, Thank you. Could you please push the changes ? Done. http://hg.openjdk.java.net/jdk8/tl/jdk/rev/399c2adf3ad6 Thanks for the contribution Shirish. -Chris. Thanks

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-13 Thread Shirish Kuncolienkar
can push it for you. -Chris. On 09/08/2012 15:38, Shirish Kuncolienkar wrote: Chris, Please go ahead and run the sanity builds and tests. Thanks -Shirish On 8/9/2012 7:52 PM, Chris Hegarty wrote: On 09/08/12 14:16, Shirish Kuncolienkar wrote: I agree there is no general documentation

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Shirish Kuncolienkar
Chris, Please go ahead and run the sanity builds and tests. Thanks -Shirish On 8/9/2012 7:52 PM, Chris Hegarty wrote: On 09/08/12 14:16, Shirish Kuncolienkar wrote: I agree there is no general documentation available, AIX defines vipa interface flag as "0x8000" In wh

Re: Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Shirish Kuncolienkar
es, I just don't see that they are required. Can you please help explain? Thanks, -Chris. On 09/08/12 11:16, Shirish Kuncolienkar wrote: Hi, The return value from the getFlags() method in NetworkInterface.c is interpreted in 2 ways. - If the value is negative an Exception is thrown - Else the

Problem with getFlags() method in NetworkInterface.c

2012-08-09 Thread Shirish Kuncolienkar
Hi, The return value from the getFlags() method in NetworkInterface.c is interpreted in 2 ways. - If the value is negative an Exception is thrown - Else the return value is considered as the flag mask obtained via the ioctl call. In rare cases is it possible the value in the ifr_flags could

Parsing of URL's which contain Windows Path separator

2012-08-09 Thread Shirish Kuncolienkar
Hi, I have the following piece of code URL url = new URL("file", "/", "C:\\temp\\Java6"); System.out.println(url); URL url1 = new URL(url, "hello.html"); System.out.println(url1); first System out prints as "file:///C:\temp\Java6\Lotus" Second one prints the valu