Re: RFR: 8272702: Resolving URI relative path with no / may lead to incorrect toString [v2]

2022-06-08 Thread KIRIYAMA Takuya
On Wed, 1 Jun 2022 14:15:31 GMT, Daniel Fuchs wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8272702: Resolving URI relative path with no / may lead to incorrect >> toString &

Re: RFR: 8272702: Resolving URI relative path with no / may lead to incorrect toString [v2]

2022-06-08 Thread KIRIYAMA Takuya
-5.2.3. > Could you review this fix? KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision: 8272702: Resolving URI relative path with no / may lead to incorrect toString - Changes: - all: https://git.openjdk.java.

Re: RFR: 8282395: URL.openConnection can throw IOOBE [v2]

2022-06-07 Thread KIRIYAMA Takuya
t; not in the ranges > 0x30 (0) to 0x39 (9), 0x41 (A) to 0x46 (F), and 0x61 (a) to 0x66 (f), all > inclusive, append byte to output. > > > So, there should be used isEscaped() to judge to decode. > > Would you please review this fix? KIRIYAMA Takuya has updated the pul

Re: RFR: 8282395: URL.openConnection can throw IOOBE

2022-06-07 Thread KIRIYAMA Takuya
On Fri, 8 Apr 2022 07:52:55 GMT, KIRIYAMA Takuya wrote: > I fixed sun.net.www.ParseUtil.decode(). > > ParseUtil.decode() always tries to decode after parsing '%', so if '%' is > located at the end of the String, IndexOutOfBoundsException is thrown. Also, &

Re: RFR: 8272702: Resolving URI relative path with no / may lead to incorrect toString

2022-05-29 Thread KIRIYAMA Takuya
On Thu, 26 May 2022 12:00:37 GMT, Alexey Ivanov wrote: > You're using the wrong bugid. > [JDK-8272707](https://bugs.openjdk.java.net/browse/JDK-8272707) has nothing > to do with URI. Please use the correct bugid. I'm sorry, I made a mistake. JDK-8272702 is correct. I fixed it. -

RFR: 8272707: Resolving URI relative path with no / may lead to incorrect toString

2022-05-26 Thread KIRIYAMA Takuya
Consider an authority component without trailing "/" as a base URI. When resolving a relative path against this base URI, the resulting URI is a concatenated URI without "/". This behaviour should be fixed, which is rationalized by rfc3986#section-5.2.3. Could you review this fix? -

Re: RFR: 8282395: URL.openConnection can throw IOOBE

2022-04-18 Thread KIRIYAMA Takuya
On Thu, 14 Apr 2022 08:47:12 GMT, Daniel Fuchs wrote: > It is not a valid escape sequence according to the spec. I see. JavaAPI document says that Escaped octets, that is, triplets consisting the percent character ('%') followed by two hexadecimal digits. Also, RFC 2396 says that '%' must be

Re: RFR: 8282395: URL.openConnection can throw IOOBE

2022-04-14 Thread KIRIYAMA Takuya
On Fri, 8 Apr 2022 09:01:40 GMT, Daniel Fuchs wrote: > MalformedURLException should probably be thrown instead of simply accepting a > malformed % encoded pair. Thank you very much for your comment. I think we should accept any codes like "%25%s%G1" according to URL standard. Is there a re

Re: RFR: 8282395: URL.openConnection can throw IOOBE

2022-04-13 Thread KIRIYAMA Takuya
On Fri, 8 Apr 2022 08:35:12 GMT, Alan Bateman wrote: > Are there examples using URL/URLconnection (rather than ParseUtil directly) > to demonstrate the issue? I’m sorry for the late reply. Thre is the example in [JDK-8282395](https://bugs.openjdk.java.net/browse/JDK-8282395). This is a simp

RFR: 8282395: URL.openConnection can throw IOOBE

2022-04-08 Thread KIRIYAMA Takuya
I fixed sun.net.www.ParseUtil.decode(). ParseUtil.decode() always tries to decode after parsing '%', so if '%' is located at the end of the String, IndexOutOfBoundsException is thrown. Also, if '%' is shown after decodable string and following string is not decodable (e.g: "%25%s%G1"), ParseUti