On Fri, 8 Apr 2022 07:52:55 GMT, KIRIYAMA Takuya <d...@openjdk.java.net> wrote:
> I fixed sun.net.www.ParseUtil.decode(). > > ParseUtil.decode() always tries to decode after parsing '%', so if '%' is > located at the end of the String, IndexOutOfBoundsException is thrown. Also, > if '%' is shown after decodable string and following string is not decodable > (e.g: "%25%s%G1"), ParseUtil.decode() throws IllegalArgumentException. > > But URL standard says below (https://url.spec.whatwg.org/#percent-decode). > > > Otherwise, if byte is 0x25 (%) and the next two bytes after byte in input are > not in the ranges > 0x30 (0) to 0x39 (9), 0x41 (A) to 0x46 (F), and 0x61 (a) to 0x66 (f), all > inclusive, append byte to output. > > > So, there should be used isEscaped() to judge to decode. > > Would you please review this fix? I am very sorry for taking long time to fix. I fixed java.net.URL#openConnection() to throw MalformedURLException when ParseUtil#decode() throws IllegalArgumentException because Javadoc says that openConnection() throws IOException if if an I/O exception occurs. Also I fixed ParseUtil#decode() not to throw IndexOutOfBoundsException when a malformed escape pair is passed. ------------- PR: https://git.openjdk.java.net/jdk/pull/8155
