On Fri, 15 Apr 2022 11:49:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO DatagramChannels
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote:
> Should I change the JBS issue title to match the PR title, or is it preferred
> for the PR title to change?
They need to match. You can either do it manually, or change the title to just
the bug number and the bot will change it for you.
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote:
> This is an initial PR for expanded lint warnings done under two bugs:
>
> 8202056: Expand serial warning to check for bad overloads of serial-related
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-tran
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote:
>> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120.
>>
>> In many places standard charsets are looked up via their names, for example:
>> absolutePath.getBytes("UTF-8");
>>
>> This could be done more efficiently(up t
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Sun, 4 Oct 2020 13:14:49 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon wr
On Fri, 2 Oct 2020 11:28:49 GMT, Michael McMahon wrote:
>> Continuing this review as a PR on github with the comments below
>> incorporated. I expect there will be a few more
>> iterations before integrating.
>> On 06/09/2020 19:47, Alan Bateman wrote:
>>> On 26/08/2020 15:24, Michael McMahon wr
Build change looks good.
/Erik
On 2019-08-16 10:32, Chris Hegarty wrote:
Adding build-dev; minor change to remove a linker dependency.
-Chris.
On 16 Aug 2019, at 18:22, Daniel Fuchs wrote:
Hi chris,
That looks good to me - although don't count me as reviewer
for the makefile changes.
bes
Build change looks fine.
/Erik
On 2018-01-25 10:46, Gary Adams wrote:
Here's a first pass attempt to remove the
-D_WINSOCK_DEPRECATED_NO_WARNINGS
build flag and update the winsock deprecated functions.
Issue: https://bugs.openjdk.java.net/browse/JDK-8080990
Webrev: http://cr.openjdk.java
Thanks, looks good now.
/Erik
On 2017-01-25 13:51, Chris Hegarty wrote:
On 24 Jan 2017, at 16:44, Erik Joelsson wrote:
Hello,
Build changes look good except for one thing. In Javadoc.gmk, the dependency on
$(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where
the
Hello,
Build changes look good except for one thing. In Javadoc.gmk, the
dependency on $(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE)
(on line 317), where the actual recipes are created. Setting it on the
phony docs-javadoc target will not help incremental builds.
/Erik
On 2017-0
Thanks, looks good!
/Erik
On 2016-04-26 12:02, Chris Hegarty wrote:
On 26 Apr 2016, at 10:57, Erik Joelsson wrote:
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a
On 2016-04-26 11:57, Erik Joelsson wrote:
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson
wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a couple style [1] nits that I would like to get sorted. In
Lib-jdk.net.gmk, the
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a couple style [1] nits that I would like to get sorted. In
Lib-jdk.net.gmk, the arguments to SetupNativeCompilation should
Hello Chris,
In general it looks good. Just a couple style [1] nits that I would like
to get sorted. In Lib-jdk.net.gmk, the arguments to
SetupNativeCompilation should be indented 4 spaces relative to the call
(continuation). Also line 32 and 45 needs a space after comma.
/Erik
[1] http://o
://cr.openjdk.java.net/~chegar/8039362/01/webrev/
On 7 Apr 2014, at 16:00, Erik Joelsson wrote:
Hello Chris,
The changes seem to do what you intend, but I have a couple of questions.
If this is a standard properties file, wouldn't it make sense to either "clean" or
"compile" it li
Hello Chris,
The changes seem to do what you intend, but I have a couple of questions.
If this is a standard properties file, wouldn't it make sense to either
"clean" or "compile" it like other properties files?
I note that there is a macosx version of this file but from what I can
see of bo
Looks good to me from a build perspective.
/Erik
On 2014-03-27 11:46, Chris Hegarty wrote:
While hunting around the build recently, when working on another SCTP bug, I
noticed a small issue where SCTP classes are being built on some platforms
unnecessarily.
Webrev:
http://cr.openjdk.java.
18 matches
Mail list logo
