Thanks, looks good!
/Erik
On 2016-04-26 12:02, Chris Hegarty wrote:
On 26 Apr 2016, at 10:57, Erik Joelsson <erik.joels...@oracle.com> wrote:
On 2016-04-26 11:51, Chris Hegarty wrote:
On 26 Apr 2016, at 10:35, Erik Joelsson <erik.joels...@oracle.com> wrote:
Hello Chris,
In general it looks good.
Thanks for the review Erik.
Just a couple style [1] nits that I would like to get sorted. In
Lib-jdk.net.gmk, the arguments to SetupNativeCompilation should be indented 4
spaces relative to the call (continuation). Also line 32 and 45 needs a space
after comma.
Got it. I updated the webrev in-place:
http://cr.openjdk.java.net/~chegar/8044773/jdk/make/lib/Lib-jdk.net.gmk.html
Now if you just move the )) back again on line 43, I'm happy.
Oh sorry, I missed this. Done.
http://cr.openjdk.java.net/~chegar/8044773/jdk/make/lib/Lib-jdk.net.gmk.html
-Chris.
