Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-19 Thread Daniel Jelinski
On Wed, 12 Jan 2022 12:34:35 GMT, Daniel Jelinski wrote: >> src/java.base/windows/native/libnet/NetworkInterface.c line 216: >> >>> 214: break; >>> 215: } >>> 216: return -1; >> >> *netifPP = NULL; >> &g

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v6]

2022-01-19 Thread Daniel Jelinski
> Clean up of various issues related to error handling and memory management Daniel Jelinski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains

Integrated: 8262442: (windows) Use all proxy configuration sources when java.net.useSystemProxies=true

2022-01-13 Thread Daniel Jelinski
On Mon, 18 Oct 2021 19:25:12 GMT, Daniel Jelinski wrote: > With this patch DefaultProxySelector first attempts to use proxy config > autodetection (http://wpad/wpad.dat) when that is configured and available. > If proxy config autodetection is unavailable, selector tries to use >

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Daniel Jelinski
On Wed, 12 Jan 2022 11:01:03 GMT, Mark Sheppard wrote: >> Daniel Jelinski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused / incorrect exit code -2 from enumInterfaces > > src/j

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v5]

2022-01-12 Thread Daniel Jelinski
> Clean up of various issues related to error handling and memory management Daniel Jelinski has updated the pull request incrementally with one additional commit since the last revision: Remove redundant initialization - Changes: - all: https://git.openjdk.java.net/jdk/p

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Daniel Jelinski
On Mon, 10 Jan 2022 19:58:56 GMT, Mark Sheppard wrote: >> In my experiments the `enumInterfaces` succeeded in IPv6-only environment. >> The function only fails with -2 when a new interface is added during >> enumeration. >> I could modify the function to stop returning -2 if you think it makes

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-01-12 Thread Daniel Jelinski
> Clean up of various issues related to error handling and memory management Daniel Jelinski has updated the pull request incrementally with one additional commit since the last revision: Remove unused / incorrect exit code -2 from enumInterfaces - Changes: - all: ht

Re: RFR: 8262442 (windows) use all proxy configuration sources when java.net.useSystemProxies=true [v2]

2022-01-11 Thread Daniel Jelinski
On Tue, 11 Jan 2022 16:33:57 GMT, Daniel Jelinski wrote: >> With this patch DefaultProxySelector first attempts to use proxy config >> autodetection (http://wpad/wpad.dat) when that is configured and available. >> If proxy config autodetection is unavailable, sel

Re: RFR: 8262442 (windows) use all proxy configuration sources when java.net.useSystemProxies=true [v2]

2022-01-11 Thread Daniel Jelinski
method > - when `lpszProxy` is configured, that proxy is used > - otherwise selector uses direct connection > > The proxy configuration scripts are cached on system level, so testing > (alternating between good and broken autoconfig script) may require waiting > for the caches

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v3]

2022-01-10 Thread Daniel Jelinski
On Sat, 8 Jan 2022 19:00:52 GMT, Mark Sheppard wrote: >> Daniel Jelinski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address problems reported by clang-tidy > > src/java.base/windows/native/libnet/Net

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v3]

2022-01-10 Thread Daniel Jelinski
On Sat, 8 Jan 2022 09:11:05 GMT, Daniel Jelinski wrote: >> Clean up of various issues related to error handling and memory management > > Daniel Jelinski has updated the pull request incrementally with one > additional commit since the last revision: > > Address probl

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v3]

2022-01-09 Thread Daniel Jelinski
On Sat, 8 Jan 2022 18:17:29 GMT, Mark Sheppard wrote: >> Daniel Jelinski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address problems reported by clang-tidy > > src/java.base/windows/native/libnet/Net

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v3]

2022-01-08 Thread Daniel Jelinski
> Clean up of various issues related to error handling and memory management Daniel Jelinski has updated the pull request incrementally with one additional commit since the last revision: Address problems reported by clang-tidy - Changes: - all: https://git.openjdk.java.