On Tue, 24 May 2022 16:20:10 GMT, Mark Powers wrote:
> Mach5 tier1 and tier2 completed without any failures. I don't know what to
> make of the pre-submit failures - lang and hotspot?
IIUC, these are due to Loom failures in some of the other platforms supported
by OpenJDK but not by Oracle. T
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Looked at
- java.base/.../sun/security
- jdk.crypto.*
- test/*/com/sun/crypto/provider
On Wed, 11 May 2022 22:38:04 GMT, Anthony Scarpino
wrote:
>> test/jdk/javax/net/ssl/SSLSession/ReadOnlyEngine.java line 162:
>>
>>> 160: statusServer != HandshakeStatus.NOT_HANDSHAKING);
>>> 161:
>>> 162: // Read NST
>>
>> What is NST?
>
> New Session Ticket
Duh, of cours
On Wed, 11 May 2022 23:03:27 GMT, Anthony Scarpino
wrote:
>> test/jdk/javax/net/ssl/SSLSession/ReadOnlyEngine.java line 172:
>>
>>> 170: out.clear();
>>> 171: String testString = "ASDF";
>>> 172: in.put(testString.getBytes()).flip();
>>
>> If you're going to convert bac
On Wed, 11 May 2022 22:25:43 GMT, Anthony Scarpino
wrote:
>> test/jdk/javax/net/ssl/SSLSession/ReadOnlyEngine.java line 1:
>>
>>> 1: /*
>>
>> Wondering why this is in javax/net/ssl/SSLSession instead of
>> sun/security/ssl/SSLCipher.
>
> I can move it.. I created it from another test which ha
On Fri, 29 Apr 2022 03:58:57 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this fix to allow a read-only 'src' buffer to be used with
> SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher
> operation when a read-only buffer is passed. If the 'src' is read
On Fri, 29 Apr 2022 03:58:57 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of this fix to allow a read-only 'src' buffer to be used with
> SSLEngine.unwrap(). A temporary read-write buffer is created in the SSLCipher
> operation when a read-only buffer is passed. If the 'src' is read
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
Sorry for the confusion.
The original intent of this bug 14 years ago was to standardize the seclibs
code where simple getProperty calls were needed in the context of an
Ac
On Thu, 28 Apr 2022 18:29:35 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Thu, 28 Apr 2022 18:29:35 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Thu, 28 Apr 2022 16:37:35 GMT, Mark Powers wrote:
>> `Security.getProperty()` does not specify the value will be `trim()`.
>
> My mistake. It's only the trim that you wanted removed, line 94.
No, the API for Security.getProperty doesn't specify trimming, so suggest
leaving the trim() part al
On Thu, 28 Apr 2022 16:22:43 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java line 92:
>>
>>> 90: static String getSecurityProperty(final String name) {
>>> 91: return AccessController.doPrivileged((Privile
On Thu, 28 Apr 2022 15:45:58 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits
On Thu, 28 Apr 2022 02:33:49 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Thu, 28 Apr 2022 15:47:44 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits
On Wed, 27 Apr 2022 15:22:08 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLSessionBindingEvent.java line
>> 37:
>>
>>> 35: * {@link SSLSession#putValue(String, Object)}
>>> 36: * or {@link SSLSession#removeValue(String)}, objects which
>>> 37: * implement the SSLSes
On Tue, 26 Apr 2022 19:49:11 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java line 69:
>>
>>> 67: String type;
>>> 68: type = AccessController.doPrivileged((PrivilegedAction)
>>> () ->
On Tue, 26 Apr 2022 19:05:05 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan Bateman comments
>
> src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java line 69:
>
>> 67: Str
On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
>
On Thu, 14 Apr 2022 18:45:10 GMT, Daniel Fuchs wrote:
>> java/net/httpclient/http2/TLSConnection.java has been observed failing (even
>> though rarely) in test jobs.
>>
>> The issue is that the handler used on the the server sides maintains a
>> volatile `sslSession` field which it sets when r
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in c
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
I learned something new abo
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
LGTM
-
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
src/java.base/share/
On Fri, 18 Mar 2022 23:05:36 GMT, Iris Clark wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more test case udpate
>
> Marked as reviewed by iris (Reviewer).
Thanks, @irisclark!
-
PR: https://g
On Tue, 8 Mar 2022 08:02:16 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
>>
On Tue, 8 Mar 2022 08:02:16 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
>>
On Tue, 8 Mar 2022 15:23:13 GMT, zzambers wrote:
>>> Sure if more changes are desired I can pull your changes. When It comes to
>>> CSR I am not fully familiar with the
>> process. Is action expected from my side?
>>
>> One of us needs to get the CSR approved. Why don't you pull the changes
On Tue, 8 Mar 2022 15:03:57 GMT, zzambers wrote:
>> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
>> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
>> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
>> performed hal
On Tue, 8 Mar 2022 15:23:13 GMT, zzambers wrote:
>>> Sure if more changes are desired I can pull your changes. When It comes to
>>> CSR I am not fully familiar with the
>> process. Is action expected from my side?
>>
>> One of us needs to get the CSR approved. Why don't you pull the changes
On Mon, 7 Mar 2022 16:34:08 GMT, zzambers wrote:
> Sure if more changes are desired I can pull your changes. When It comes to
> CSR I am not fully familiar with the
process. Is action expected from my side?
One of us needs to get the CSR approved. Why don't you pull the changes
described in:
On Mon, 7 Mar 2022 20:39:44 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java
>> line 158:
>>
>>> 156: } catch (GeneralSecurityException gse) {
>>> 157: throw new SSLHandshakeException(
>>> 158:
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
>>
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
>>
On Mon, 7 Mar 2022 07:52:29 GMT, Xue-Lei Andrew Fan wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
> Plea
On Thu, 3 Mar 2022 12:36:33 GMT, zzambers wrote:
>> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
>> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
>> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
>> performed hal
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
LGTM also.
Similar suggestion for updating copyrights.
-
Marked as reviewed by wetmore (Reviewer).
PR: https:/
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote:
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
> performed half-cl
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote:
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was
> introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() /
> Socket.shutdownOutput() and InputStream.close() / OutputStream.close()
> performed half-cl
On Mon, 8 Nov 2021 22:59:30 GMT, Bradford Wetmore wrote:
> Minor typos.
This pull request has now been integrated.
Changeset: 38e6d5d6
Author: Bradford Wetmore
URL:
https://git.openjdk.java.net/jdk/commit/38e6d5d6ed967f68e6ac1bfaa285efa16577c790
Stats: 3 lines in 2 files chan
Minor typos.
-
Commit messages:
- Forgot copyright date
- 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl
Changes: https://git.openjdk.java.net/jdk/pull/6301/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6301&range=00
Issue: https://bugs.openj
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov
wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-re
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov
wrote:
>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274809: Update java.base classes to use try-with-re
On Wed, 6 Oct 2021 16:07:12 GMT, Bradford Wetmore wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> update copyrigh
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
I checked the rest. The one BufferedInputStream change is puzzling. Please
explain or address.
Files like HttpTimestamper need the copyright dates updated to 2021.
src/java
On Tue, 5 Oct 2021 09:36:23 GMT, Andrey Turbanov
wrote:
> 8274809: Update java.base classes to use try-with-resources
Reviewed the crypto/security files.
src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java line
115:
> 113:
> 114: // Send the request
> 115:
On Fri, 27 Aug 2021 01:35:17 GMT, Bradford Wetmore wrote:
> Did a quick sweep of some minor non-standard javadoc issues. This silences
> 3rd party tooling warnings and fixes some linkage issues.
This pull request has now been integrated.
Changeset: 76baace2
Author:Bradford Wetmor
> Did a quick sweep of some minor non-standard javadoc issues. This silences
> 3rd party tooling warnings and fixes some linkage issues.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comment
-
C
On Fri, 27 Aug 2021 03:38:55 GMT, Xue-Lei Andrew Fan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comment
>
> src/java.base/share/classes/javax/net/ssl/SNIHostName.
Did a quick sweep of some minor non-standard javadoc issues. This silences 3rd
party tooling warnings and fixes some linkage issues.
-
Commit messages:
- 8273045: Fix misc javadoc bugs in the java.security and javax.net.ssl code
Changes: https://git.openjdk.java.net/jdk/pull/5271/
On Mon, 12 Jul 2021 20:39:53 GMT, Christoph Langer wrote:
> The change for JDK-8257001 left an obsolete int field. Remove it.
Marked as reviewed by wetmore (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4759
On Wed, 26 May 2021 01:12:14 GMT, Bradford Wetmore wrote:
> Missed updating today's changeset with the new variable name.
>
> It's a "one character fix."
This pull request has now been integrated.
Changeset: b33b8bc8
Author:Bradford Wetmore
URL:
htt
Missed updating today's changeset with the new variable name.
It's a "one character fix."
-
Commit messages:
- 8267750: Incomplete fix for JDK-8267683
Changes: https://git.openjdk.java.net/jdk/pull/4196/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4196&range=00
Is
Simple typo fix. Somehow the trailing "u" got omitted, so the code won't parse
when fed into the compiler.
Resulting javadoc output now compiles.
-
Commit messages:
- Codereview Comments.
- 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters
javadoc
Changes:
On Tue, 25 May 2021 18:03:51 GMT, Bradford Wetmore wrote:
> Simple typo fix. Somehow the trailing "u" got omitted, so the code won't
> parse when fed into the compiler.
>
> Resulting javadoc output now compiles.
This pull request has now been integrated.
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote:
> Certain TLS ALPN values can't be properly read or written by the SunJSSE
> provider. This is due to the choice of Strings as the API interface and the
> undocumented internal use of the UTF-8 Character Set which converts
On Thu, 26 Nov 2020 20:26:36 GMT, Xue-Lei Andrew Fan wrote:
>> Certain TLS ALPN values can't be properly read or written by the SunJSSE
>> provider. This is due to the choice of Strings as the API interface and the
>> undocumented internal use of the UTF-8 Character Set which converts
>> chara
On Wed, 25 Nov 2020 20:03:01 GMT, Bradford Wetmore wrote:
> Certain TLS ALPN values can't be properly read or written by the SunJSSE
> provider. This is due to the choice of Strings as the API interface and the
> undocumented internal use of the UTF-8 Character Set which converts
On Thu, 26 Nov 2020 10:33:26 GMT, Daniel Fuchs wrote:
>> Certain TLS ALPN values can't be properly read or written by the SunJSSE
>> provider. This is due to the choice of Strings as the API interface and the
>> undocumented internal use of the UTF-8 Character Set which converts
>> characters
Certain TLS ALPN values can't be properly read or written by the SunJSSE
provider. This is due to the choice of Strings as the API interface and the
undocumented internal use of the UTF-8 Character Set which converts characters
larger than U+7F into multi-byte arrays that may not be expected
On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy
wrote:
>> 1) This is un-necessary churn.
>> 2) I can't even be sure I am finding the ones in my area because there's so
>> much here
>> 3) The ones I can find have no need of whatever performance improvement this
>> might bring.
>> I think th
AbstractDelegateHttpsURLConnection.java
---
74/88/etc. I haven't checked for sure, but IIRC we made setNewClient
public from protected and other such changes in order for these classes
to use the delegation model and allow calls to both sun/net/www/protocol
+1.
Brad
On 11/14/2017 11:47 AM, Roger Riggs wrote:
+1, Reviewed
Roger
On 11/14/2017 2:45 PM, Ivan Gerasimov wrote:
Hello!
A typo in the javadoc:
--- a/src/java.base/share/classes/java/net/InetAddress.java
+++ b/src/java.base/share/classes/java/net/InetAddress.java
@@ -1133,7 +1133,7 @@
Looks good, thanks.
brad
On 6/8/2016 1:16 AM, Chris Hegarty wrote:
On 8 Jun 2016, at 03:36, Hamlin Li wrote:
On 2016/6/8 4:27, Bradford Wetmore wrote:
May I suggest using example.com [1] and an arbitrary path instead on these two
examples, so that there's no chance of it being mis
May I suggest using example.com [1] and an arbitrary path instead on
these two examples, so that there's no chance of it being mistaken for a
valid URL. This example uses old hostnames that might change yet again
(docs.oracle.com) and an ancient JDK platform (1.3), let's just remove
that confu
I just would like to remind that session resumption is a very
important use case to support for ALPN.
Understood. The ALPN value is tied to a handshake, either already
completed and active (getApplicationProtocol()) or still in progress
(getHandshakeApplicationProtocol()). Each handshake r
298: This test is not actually calling into checkResult on the server side.
Ooops! You need to check the output of the wrap() before calling unwrap() as
it overwrites the serverResult. You need to put in a similar checkResult()
before doing the flip()s.
So checks are required before and
On 11/29/2015 4:08 PM, Vincent Ryan wrote:
> Following on from Brad’s recent email, here is the full webrev of the
> API and the implementation classes for ALPN:
> http://cr.openjdk.java.net/~vinnie/8144093/webrev.00/
>
> In adds the implementation classes (sun/security/ssl) to the public API
>
On 10/6/2015 7:42 AM, David M. Lloyd wrote:
I didn't reply on this last week, but this looks workable to me. Thanks!
Thanks to you guys for all the discussion!
During the architectural review, it was pointed out that the
SSLParameters.setApplicationProtocols() API proposal with the
server-
u think it is worth to write/update tests for the new suggestion
from the javadoc?
No, just that you made the javadoc target and it built ok. I've seen
javadoc typos which caused the build to fail. Just making sure that
didn't happen here.
Brad
-- Sebastian
On 11/06/201
This bug talks about not only javadoc, but the actual code as well. It
looks like someone has already hit all of that, so this is the only
thing left.
What you've proposed looks ok. Did you make the javadocs target to test?
Brad
On 11/5/2015 7:42 PM, Sebastian Sickelmann wrote:
Hi, i wa
On Sat, Oct 3, 2015 at 2:19 AM, Bradford Wetmore
wrote:
Thanks for the comments everyone. I'm submitting the following to the CCC
(internal review board):
http://cr.openjdk.java.net/~wetmore/8051498/webrev.17/
Changes:
1. No H2 Blacklist/Comparator
2. set/getApplicationProt
On 10/1/2015 7:35 PM, Xuelei Fan wrote:
On 10/2/2015 9:03 AM, Bradford Wetmore wrote:
Major changes:
1. ApplicationProtocols is gone. The H2 black list and comparator were
moved to StandardConstants.
2. StandardConstants. Strings for "h2" and "http/1.1" are back.
H2 will not be backported into the URL mechanism
and doesn't see a need for it yet, so I'm inclined to say no.
More inline:
On 9/29/2015 8:07 AM, David M. Lloyd wrote:
Hi Brad, thanks for replying; comments are inline:
On 09/28/2015 08:40 PM, Bradford Wetmore wrote:
1. On
Several comments about David's proposal:
1. Only the initial ClientHellos are parsable.
===
The biggest problem I have with an Explorer-based design is that only
the initial ClientHello on a connection is passed in the clear.
Subsequent negotiations
You guys certainly were prolific in your discussions last night. ;)
Many comments to touch on, and I definitely won't have time today to
respond to everything.
Xuelei wrote:
> I don't think we really need to re-order the cipher suites.
Simone wrote:
> Of course you need to re-order in this
On 9/23/2015 2:33 AM, Simone Bordet wrote:
Hi,
On Wed, Sep 23, 2015 at 7:04 AM, Bradford Wetmore
wrote:
This new proposal still requires that ciphers are sorted in a way that
matches the ApplicationProtocol order.
Would be nice if, along with the HTTP/2 blacklist, there is a HTTP/2
> This new proposal still requires that ciphers are sorted in a way that
> matches the ApplicationProtocol order.
> Would be nice if, along with the HTTP/2 blacklist, there is a HTTP/2
> comparator that sorts ciphers putting the blacklisted ones at the end.
Hm...is the sample code at the end of
Hi all,
On 9/7/2015 7:18 AM, Simone Bordet wrote:
On Mon, Sep 7, 2015 at 5:54 AM, Bradford Wetmore
wrote:
In general, if the ciphersuites aren't ordered properly, that should be
considered a configuration error on the part of the application(s). However,
this dynamic ALPN selection app
Hi all,
Simone/Xuelei/I wrote:
Per my understanding, application protocol should be negotiated before
>>>cipher suite and protocol version negotiated.
>>
>>This is not possible for HTTP/2.
>>Application protocol negotiation MUST happen*after* the TLS protocol
>>and the TLS cipher are negotiat
There is a similar one for HttpsURLConnection, as we had problems in the
past where the networking changes didn't update the SSL code.
jdk/sun/net/www/protocol/https/HttpsURLConnection/CheckMethods.java
Just a reminder to please include the JSSE reg tests when making
Socket/HttpsURLConnect
Chris/Ivan's changes look good to me.
Brad
On 3/31/2014 7:59 AM, Chris Hegarty wrote:
Thanks Ivan, I'll add them.
-Chris.
On 31/03/14 15:48, Ivan Gerasimov wrote:
Hi Chris!
Would it be good to include a couple more typo fixes in this change?
diff --git a/src/share/classes/java/net/Datagra
Changeset: f731d096530f
Author:wetmore
Date: 2013-10-30 16:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f731d096530f
8027526: CheckTipsAndVersions.java failing occasionally
Reviewed-by: mullan, mchung
! test/java/security/Signature/SignatureGetAlgorithm.java
Changeset: 1a71d800b032
Author:wetmore
Date: 2013-10-16 23:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/1a71d800b032
8026762: jdk8-tl builds windows builds failing in corba - javac: no source files
Reviewed-by: katleman, dholmes
! makefiles/BuildCorba.gmk
Changeset: a45acc8de0f3
Author:wetmore
Date: 2013-10-16 23:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a45acc8de0f3
8026762: jdk8-tl builds windows builds failing in corba - javac: no source files
Reviewed-by: katleman, dholmes
! makefiles/GenerateClasses.gmk
Changeset: a6ac824b463d
Author:wetmore
Date: 2013-10-02 09:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ac824b463d
8025694: Rename getStrongSecureRandom based on feedback
8014838: getStrongSecureRandom() should require at least one implementation
Reviewed-by: mullan, d
Changeset: f8af3499c1fb
Author:wetmore
Date: 2013-08-14 19:19 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8af3499c1fb
8023075: JDK-5049299 has broken old make in jdk8
Reviewed-by: katleman
! make/java/java/Makefile
Changeset: 11c15607e43f
Author:wetmore
Date: 2013-07-05 18:22 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11c15607e43f
8019341: Update CookieHttpsClientTest to use the newer framework.
Reviewed-by: xuelei, smarks, michaelm
!
test/sun/security/ssl/sun/net/www/protocol/htt
Changeset: 116050227ee9
Author:youdwei
Date: 2013-06-17 17:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9
8014620: Signature.getAlgorithm return null in special case
Reviewed-by: wetmore
! src/share/classes/java/security/Signature.java
+ test/java/security/Si
Changeset: b600d637ef77
Author:wetmore
Date: 2013-04-25 17:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d637ef77
8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing
Reviewed-by: wetmore
Contributed-by: alan.bate...@oracle.com
! test/sun/se
Changeset: 6379415d8fca
Author:wetmore
Date: 2013-03-12 15:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6379415d8fca
8009925: Back out AEAD CipherSuites temporarily
Reviewed-by: valeriep
! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
! src/shar
Changeset: 13b46e8eda33
Author:ohrstrom
Date: 2012-10-23 15:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13b46e8eda33
8001419: Build the JCE portion of JDK-8000970
Summary: Original code done by Fredrik Ohrstrom, separated/pushed by wetmore
Reviewed-by: wetmore
! src/sh
Changeset: 940c8cc5a5c4
Author:wetmore
Date: 2012-10-23 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/940c8cc5a5c4
7197071: Makefiles for various security providers aren't including the default
manifest
Reviewed-by: valeriep, mullan, katleman
! make/com/oracle/securi
Changeset: 8e5635ded425
Author:wetmore
Date: 2012-06-15 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e5635ded425
7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked
Reviewed-by: khazra
! test/ProblemList.txt
Changeset: 6438f1277df6
Author:wetmore
Date: 2012-05-09 16:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6438f1277df6
7167362: SecureRandom.init should be converted, amendment to 7084245
Reviewed-by: sherman
! src/share/classes/sun/security/provider/SecureRandom.java
Changeset: 10480cf00dcd
Author:wetmore
Date: 2012-04-11 17:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10480cf00dcd
7157903: JSSE client sockets are very slow
Reviewed-by: xuelei
! src/share/classes/sun/security/ssl/AppOutputStream.java
! src/share/classes/sun/security
Changeset: 7a7dcbbd610f
Author:wetmore
Date: 2012-03-30 15:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a7dcbbd610f
7142172: Custom TrustManagers that return null for getAcceptedIssuers will NPE
Reviewed-by: xuelei
! src/share/classes/sun/security/ssl/SSLContextImpl.ja
Changeset: b16cbeb0d213
Author:wetmore
Date: 2012-02-10 19:07 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b16cbeb0d213
7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when
in.remaining() == 0
Reviewed-by: valeriep
! src/share/classes/javax/crypto/CipherSp
Changeset: 55a82eba1986
Author:wetmore
Date: 2012-02-01 16:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55a82eba1986
7141910: Incorrect copyright dates on new test cases.
Reviewed-by: mullan
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOn
1 - 100 of 213 matches
Mail list logo
