On Fri, 27 Aug 2021 03:38:55 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Codereview Comment > > src/java.base/share/classes/javax/net/ssl/SNIHostName.java line 37: > >> 35: import java.util.Objects; >> 36: import java.util.regex.Pattern; >> 37: import java.util.regex.PatternSyntaxException; > > Does it mean that the classes introduced in java doc should also be imported? > Maybe, the path package names could be removed in the createSNIMatcher() > method spec. > > - * @throws java.util.regex.PatternSyntaxException if the regular > expression's > - * syntax is invalid > + * @throws PatternSyntaxException if the regular expression's syntax is > invalid Thanks for the catch. It doesn't absolutely have to be fixed to get javadoc to run (it apparently is a good guesser), but 3rd party tools like IntelliJ Idea aren't as robust, and treat this as an error. In the second update, I removed the extra package name in setSNIMatcher. Thanks for the review. I'll go ahead and push. ------------- PR: https://git.openjdk.java.net/jdk/pull/5271
