Re: RFR: 8019341: Update CookieHttpsClientTest to use the newer framework.

2013-07-05 Thread Brad Wetmore
On 7/2/2013 8:29 PM, Xuelei Fan wrote: On 7/3/2013 8:30 AM, Brad Wetmore wrote: http://cr.openjdk.java.net/~wetmore/8019341/webrev.01/ 261 // If both failed, return the curthread's exception. 262 local.initCause(remote); The mix the initial cause of the exception would ma

Re: RFR: 8019341: Update CookieHttpsClientTest to use the newer framework.

2013-07-02 Thread Brad Wetmore
Michael wrote: > I'd agree with this. If the exception is being swallowed now, how > will we know when the test fails? The "peer" thread saves off any Exceptions into {server,client}Exception volatile variable, which is then examined by the main thread at the end, and the stacktrace would be s

RFR: 8019341: Update CookieHttpsClientTest to use the newer framework.

2013-06-27 Thread Brad Wetmore
Chris (and Michael), As my part of the "intermittently failing test cleanup," I'm looking into a test of yours that has been intermittently failing. It's bug: https://jbs.oracle.com/bugs/browse/JDK-8017333 which is failing the regression test you added for: http://hg.openjdk.java.ne

Re: RFR 8006560: java/net/ipv6tests/B6521014.java fails intermittently

2013-01-18 Thread Brad Wetmore
Looks good to me. Don't know how many of those we've cleaned over the years! ;) Brad On 1/18/2013 6:23 AM, Chris Hegarty wrote: This test can be seen to fail intermittently on a very busy system. The test tries to bind to a "hardcoded" (relative to another) port number. I see no reason for

Re: Indenting code?

2012-09-13 Thread Brad Wetmore
Netbean's automatic formatting does a pretty good job with new code. However, I think the general advice is to not change existing code just because. When you're dealing with multiple release families, it makes the merges much more difficult. Brad On 9/13/2012 6:18 AM, John Zavgren wrote:

Re: OpenJDK 7 SNI Implementation

2012-08-22 Thread Brad Wetmore
Cross-posting to security-dev. Hi Tim, On 8/21/2012 8:07 PM, Tim Gustafson wrote: I see that Java is supposed to support SNI, but it's not clear to me how this happens, or where it happens, or if support for SNI extends only to client SSLSocket object, or if it also applies to SSLServerSocket

Re: Code review request [JDK 8]: 7132248, sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing

2012-01-24 Thread Brad Wetmore
Looks good also... Brad On 1/23/2012 4:27 AM, Xuelei Fan wrote: Remove the serviceabilty-dev. Thanks for the quick code review. Xuelei On 1/23/2012 8:25 PM, Alan Bateman wrote: On 23/01/2012 12:21, Xuelei Fan wrote: Webrev: http://cr.openjdk.java.net/~xuelei/7132248/webrev.00/ In JDK 8,

Re: Code Review Request: 7035556 DatagramSocket.java:183: warning: unreachable catch clause

2011-07-21 Thread Brad Wetmore
Kurchi, Please have an additional reviewer for the networking portion of this, but in doing a quick look, I believe the point of the two catches is to make sure that any IOException that isn't already a SocketException (SocketException is a subclass of IOException) is rebranded to SocketExcep

Patch submission.

2011-05-12 Thread Brad Wetmore
Hi Net-folks, There is a patch in bugs.openjdk.java.net which was originally filed under security, but it is probably more of a network issue. It involves the "jar" protocol. See the thread thus far at: http://mail.openjdk.java.net/pipermail/security-dev/2011-May/003269.html I've filed:

Re: hg: jdk7/tl/jdk: 6626257: Update SWAN-specific webcaching to Oracle environment in the regression tests.

2011-04-14 Thread Brad Wetmore
Internally, we've been moving from the Sun network environment to Oracle's for about a year now, and we lose various bits of connectivity which sends us scrambling. On 4/14/2011 7:01 AM, Chris Hegarty wrote: On 04/14/11 02:45 PM, Dr Andrew John Hughes wrote: On 14 April 2011 00:17, wrote: Ch

Re: Code Review 6969395: TEST_BUG: Tests in java/net sun/net problems

2010-07-21 Thread Brad Wetmore
I notice you've changed a lot of http server tests to run in othervm mode. Do they have to run in othervm mode? Just thinking about the overall test time. In samevm mode all the http server tests that use SSL fail with java.lang.NoClassDefFoundError: "Could not initialize class javax.crypto.Jc

Re: [security-dev 01698]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Brad Wetmore
I have a couple important tasks to finish ASAP, so if there is more discussion, I'll have to jump in sometime next week, but wanted to add one thing before anything was done: Pavel wrote: > And we can use other URL if verisign.com is problematic. We've tried to limit the reliance on servers outs

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Brad Wetmore
> Oh, I agree. I just thought I'd use the opportunity to point out to > everyone that a) there is some documentation of this and, more > importantly, b) it needs updating. Kelly's been following this thread, but I haven't seen the note about the webrev here. His latest webrev (posted to guide-

Re: Reg : How to contribute

2009-07-15 Thread Brad Wetmore
Pugal.G, The project website is a good place to start. http://openjdk.java.net/ Specifically, the process for contributions is at: http://openjdk.java.net/contribute/ Good luck, hope you find something of interest. Brad Ganesan Pugalendhi wrote: Hi I have more then 6+ years of

Re: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ...

2008-12-19 Thread Brad Wetmore
If you want to see the source change now, check out the changeset: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b89ba9a6d9a6 This change will not be seen immediately in the JDK7 snapshot source and binaries. As you may know, we use a series of subgates to make development and testing easier, a

JSN Gate is being EOL'd.

2008-10-16 Thread Brad Wetmore
As you may know, I have been the gatekeeper for the JSN (Java Security & Networking) gate for the last 4 or so years. As many of JSN and TL (Tools & Libraries) changes are interrelated, we have been combining/testing/integrating the JSN & TL changes together into the MASTER workspaces. JSN

No JSN integration today.

2008-09-08 Thread Brad Wetmore
Only had two minor putbacks this time around, we'll give our SQE team a break. :) Brad

Re: Heads up: Bad changeset rollback

2008-09-04 Thread Brad Wetmore
The current policy is still one putback per bugid. There have been other really good reasons to allow more than one (pre-built JCE binaries), but so far no change in the policy. I still do wish it were changed, as filing a separate bug just to do a JCE build is wasted work, IMHO. > Although

Heads up: Bad changeset rollback

2008-09-03 Thread Brad Wetmore
Last night there was a changeset introduced to the JSN gate that contained an incorrect changeset comment. Rather than pollute the changeset history for everyone, we're going to rollback this changeset, and have the author redo his changeset and push. Since this problem was noticed within 1

Any more JSN putbacks?

2008-08-25 Thread Brad Wetmore
Today is JSN integration day. I'd like to start early, but will wait for any last pushes. Brad

Issue in the JSN gate.

2008-07-28 Thread Brad Wetmore
Hi, This morning's networking changeset in the JSN gate appears to have broken several of the reg/unit tests under 64-bit. 6730740: Fix for 6729881 has apparently broken several 64 bit tests: "Bad address" The TL gate normally closes and builds for PIT at 10pm PST tonight

Any more putbacks for this week's integration?

2008-05-12 Thread Brad Wetmore
Let me know soon, I'd like to start the builds. Brad

JSN/TL integration slot pushed back 1 week.

2008-05-01 Thread Brad Wetmore
Because of JavaOne being next week, we'll be doing an integration the week after J1 instead of next week. Brad

No JSN integration today.

2008-04-21 Thread Brad Wetmore
Hi gang, I had a couple of problems with the latest integration builds/tests, so I decided to hold off on a TL integration until we understand these failures better. If there was anything that *REALLY* needs to be in TL/MASTER for this build, please let me know. We're still really early in

JSN Integration deadline at 3pm

2008-03-31 Thread Brad Wetmore
We're still assessing if I will do a JSN integration this week, but if so, I'll take my snapshot at soon and start the ball rolling. There are some PKCS11 changes that are causing some JCK and test failures, and need investigation for impact before we integrate in TL/MASTER. If there are an

First JSN codefreeze is next Monday at noon.

2008-03-14 Thread Brad Wetmore
As per: http://openjdk.java.net/projects/jdk7/builds/ Our first mercurial integration for b25 into the MASTER is next Friday, so in order to get our PreIntegration Testing (PIT) done in time, our JSN codefreeze will be Monday at noon (Pacific time), so we can get the JSN changes into the TL

Introductory JSN Gate information

2008-03-12 Thread Brad Wetmore
(This is old hat to those developers who integrate into the JSN (Java Security and Networking) gate, but for those who aren't familiar with the gate, here's the quick intro. Those who know the process need not read further.) Hello again from your JSN gatekeeper, Executive Summary: ===

JSN gate notifications.

2008-03-06 Thread Brad Wetmore
Hi net-dev'ers, This is Brad Wetmore, your friendly neighborhood JSN gatekeeper. For some reason, pushes to the various JSN gates were initially configured to send notifications only to the security group's aliases. That problem has been fixed, and notifications should now go t