On 6/29/20 11:01 PM, Daniel Fuchs wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8246114/webrev.01/
Looks good. (And I verified the fix on the system where issue reproducible.)
Thank you Daniel!
Thanks,
Amy
Thank you Julia!
Looks good to me.
Thanks,
Amy
On 3/24/20 11:01 PM, Julia Boes wrote:
Hi Amy,
Just a minor comment on the test usage of
/othervm/java.security.policy=FilePublisherPermsTest3.policy
-Djava.security.manager
As jtreg tag-spec [1] suggested:
The setting of the system propert
On 3/24/20 1:51 AM, Julia Boes wrote:
Updated webrev:
http://cr.openjdk.java.net/~jboes/webrevs/8235459/webrev.03/
Hi, Julia
Just a minor comment on the test usage of
/othervm/java.security.policy=FilePublisherPermsTest3.policy
-Djava.security.manager
As jtreg tag-spec [1] suggested:
The
Thank you Christoph and Chris!
Change pushed.
Thanks,
Amy
On 2/27/19 6:03 PM, Chris Hegarty wrote:
+1
-Chris.
On 27/02/2019 09:31, Langer, Christoph wrote:
Hi Amy,
seems reasonable to me. +1
Best regards
Christoph
-Original Message-
From: core-libs-dev On Behalf
Of Amy Lu
Sent
java/net/MulticastSocket/SetGetNetworkInterfaceTest.java
Test fails due to JDK-8219083 (failures observed on windows-x64) and
should be problem listed before mentioned issue fixed.
Please review the patch.
bug: https://bugs.openjdk.java.net/browse/JDK-8219802
Thanks,
Amy
--- old/test/jdk/Pr
sun/net/www/protocol/file/DirPermissionDenied.java
+
+ @BeforeTest
+ public void setup() throws Throwable {
+ // mkdir and chmod "333"
+ Files.createDirectories(TEST_DIR);
+ ProcessTools.executeCommand("chmod", "333", TEST_DIR.toString()) Maybe just
do this with java api instead run chmod comman
Hi, Felix
I noticed that CompilerUtils from jdk/test/lib/testlibrary is still used
in tests. It’s better to use the version [1] from top level.
(Not a reviewer.)
Thanks,
Amy
[1]
http://hg.openjdk.java.net/jdk10/jdk10/file/tip/test/lib/jdk/test/lib/compiler/CompilerUtils.java
On 5/26/17 11
Good to see one more script test be changed to java, thank you Felix.
I'm not official reviewer, but some minor comments.
30 * @library /lib/testlibrary
31 * @build jdk.testlibrary.*
32 * @compile LookupTest.java
I noticed test requires testlibrary, but seems test do not actually
depen
sun/net/www/protocol/jar/B4957695.java
This test is to verify that no jar_cache tmpFile left in temp directory
when IOException occurs.
Test do stream reading and trigger IOException and compare the jar_cache
file number before and after this action (that triggered the IOException):
Please review.
Thanks,
Amy
On 8/22/16 4:37 PM, Amy Lu wrote:
java/net/URLPermission/nstest/lookup.sh
This test is known to fail intermittently (JDK-8156504), this patch is
to mark the test accordingly with keyword 'intermittent'.
bug: https://bugs.openjdk.java.net/browse/JDK-8164
java/net/URLPermission/nstest/lookup.sh
This test is known to fail intermittently (JDK-8156504), this patch is
to mark the test accordingly with keyword 'intermittent'.
bug: https://bugs.openjdk.java.net/browse/JDK-8164545
webrev: http://cr.openjdk.java.net/~amlu/8164545/webrev.00/
Thanks,
Am
, instead, I will send out
an RFR, soon, to resolve the intermittent issue with the test itself.
-Chris.
On 18 Jul 2016, at 06:48, Amy Lu wrote:
Below tests have been observed to fail intermittently with relatively high
frequency:
java/net/httpclient/SplitResponse.java (JDK-8157533)
java/net
Please review.
Thanks,
Amy
On 7/18/16 1:48 PM, Amy Lu wrote:
Below tests have been observed to fail intermittently with relatively
high frequency:
java/net/httpclient/SplitResponse.java (JDK-8157533)
java/net/URLPermission/URLTest.java (JDK-8078568)
Please review this patch to put them to
Below tests have been observed to fail intermittently with relatively
high frequency:
java/net/httpclient/SplitResponse.java (JDK-8157533)
java/net/URLPermission/URLTest.java (JDK-8078568)
Please review this patch to put them to problem list until issues addressed.
bug: https://bugs.openjdk.ja
sun/net/www/http/ChunkedOutputStream/checkError.java
This test failed intermittently (JDK-8041924), and recently observed
failing with high frequency.
Please review this patch to put the test to problem list until
JDK-8041924 is addressed.
bug: https://bugs.openjdk.java.net/browse/JDK-815901
Below tests are known to fail intermittently. This patch is to mark the
test accordingly with keyword 'intermittent’ until issue resolved.
java/net/MulticastSocket/TestInterfaces.java (JDK-8134989)
java/net/DatagramSocket/PortUnreachable.java (JDK-8085875)
java/net/InetAddress/IsReachableViaLoop
On 4/28/16 12:50 PM, John Jiang wrote:
Hi,
Please review another webrev:
http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
The java.httpclient module declaration is removed from all of
java/net/httpclient tests, even though some ones have to declare other
modules.
+ * @modules jdk.httpser
Please review.
Thanks,
Amy
On 3/4/16 7:59 PM, Amy Lu wrote:
Below tests are known to fail intermittently, this patch is to mark
them accordingly with keyword 'intermittent'.
java/net/URLPermission/URLTest.java (JDK-8078568)
java/net/ipv6tests/TcpTest.java (JDK-8078577)
Below tests are known to fail intermittently, this patch is to mark them
accordingly with keyword 'intermittent'.
java/net/URLPermission/URLTest.java (JDK-8078568)
java/net/ipv6tests/TcpTest.java (JDK-8078577)
bug: https://bugs.openjdk.java.net/browse/JDK-8151260
webrev: http://cr.openjdk.java.
On 12/18/15 6:07 PM, Paul Sandoz wrote:
On 18 Dec 2015, at 10:42, Amy Lu wrote:
Change looks fine. Thank you for the update Felix.
(But please wait for the final GO from one official reviewer.)
+1
Amy, can you sponsor?
Thanks,
Paul.
Thank you Paul for review.
Yes!
I can push this for
Change looks fine. Thank you for the update Felix.
(But please wait for the final GO from one official reviewer.)
Thanks,
Amy
On 12/16/15 1:35 PM, Felix Yang wrote:
Chris/Paul/Amy,
thank you very much for your comments. I produced a new webrev by
1) renaming isWindows to "IS_WINDOWS'
2) r
Hi, Felix
I'm not openjdk reviewer, just a minor comment here.
You may want to remove "intermittent" key from this test along with your
fix.
- * @key intermittent
Thanks,
Amy
On 12/14/15 2:53 PM, Felix Yang wrote:
Hi all,
please review the fix for
java/net/NetworkInterface/NetworkInt
22 matches
Mail list logo
