Re: RFR: 8279329: Remove hardcoded IPv4 available policy on Windows

2022-02-07 Thread Masanori Yano
On Wed, 2 Feb 2022 12:32:13 GMT, Alan Bateman wrote: >> I added socket connection check same as IPv6_supported(). >> Before this fix, when IPv4 is uninstalled (called `netsh interface ipv4 >> uninstall`), and set property `-Djava.net.preferIPv4Stack=true`, >> java.net.InetAddress.PLATFORM_LOOKU

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 22:56:45 GMT, Xue-Lei Andrew Fan wrote: >> Sorry, you will have to bear with me as I am still not sure how it works - I >> want to know who wins, the API or the properties, if both are set and I >> can't find where it answers that above. Maybe I need to read the code. Are >>

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 22:18:03 GMT, Sean Mullan wrote: >> I think lines 714-816/723-725 describe the behavior already. >> >> I was hesitate to use "override", as the System Property values and the >> default signature schemes are not actually overrode. The default signature >> schemes are still

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Sean Mullan
On Mon, 7 Feb 2022 22:00:21 GMT, Xue-Lei Andrew Fan wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 744: >> >>> 742: * the {@systemProperty jdk.tls.client.SignatureSchemes} and/or >>> 743: * {@systemProperty jdk.tls.server.SignatureSchemes} system >>> prope

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 19:59:32 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct null tags > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 47: > >> 45: * >> 46: *

Re: RFR: 8280494: (D)TLS signature schemes [v14]

2022-02-07 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 > Release-note: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Feb 2022 19:51:28 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct null tags > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 744: > >> 742: * the

Re: RFR: 8280494: (D)TLS signature schemes [v13]

2022-02-07 Thread Sean Mullan
On Fri, 4 Feb 2022 20:58:46 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-8

Integrated: 8280965: Tests com/sun/net/httpserver/simpleserver fail with FileSystemException on Windows 11

2022-02-07 Thread Julia Boes
On Thu, 3 Feb 2022 09:24:46 GMT, Julia Boes wrote: > This change updates the tests in question to handle the case where sym link > creation is not supported, as observed on Windows 11 where additional > privileges are required to create sym links. > > Testing: tier 1-3 across platforms, plus t

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v4]

2022-02-07 Thread Daniel Jeliński
On Wed, 19 Jan 2022 08:15:46 GMT, Daniel Jeliński wrote: >> Why? >> No users of `enumInterfaces` rely on the value returned in the second >> parameter when `enumInterfaces` returns a negative result. The same is true >> for `getAllInterfacesAndAddresses`. >> The second parameter was NULL-initia

Re: RFR: 8275640 (win) java.net.NetworkInterface issues with IPv6-only environments [v7]

2022-02-07 Thread Daniel Jeliński
> Clean up of various issues related to error handling and memory management Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Initialize return value in all cases - Changes: - all: https://git.openjdk.java.net/jdk/pu