Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Sergey Bylokhov
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Mandy Chung
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Mandy Chung
On Fri, 19 Nov 2021 18:15:46 GMT, Brent Christian wrote: >> src/java.base/share/classes/java/lang/Object.java line 481: >> >>> 479: * system resources or to perform other cleanup. >>> 480: * >>> 481: * When running in a Java virtual machine in which finalization >>> has been >>

Integrated: 8274949: Use String.contains() instead of String.indexOf() in java.base

2021-11-19 Thread Andrey Turbanov
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov wrote: > String.contains was introduced in Java 5. > Some code in java.base still uses old approach with `String.indexOf` to check > if String contains specified substring. > I propose to migrate such usages. Makes code shorter and easier to read

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Brent Christian
On Fri, 19 Nov 2021 18:06:39 GMT, Mandy Chung wrote: >> Here are the code changes for the "Deprecate finalizers in the standard Java >> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code >> review. >> >> This change makes the indicated deprecations, and updates the API spe

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Mandy Chung
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Joe Darcy
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Lance Andersen
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Alan Bateman
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-19 Thread Roger Riggs
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote: > Here are the code changes for the "Deprecate finalizers in the standard Java > API" portion of JEP 421 ("Deprecate Finalization for Removal") for code > review. > > This change makes the indicated deprecations, and updates the API spec

Integrated: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie

2021-11-19 Thread Daniel Fuchs
On Tue, 16 Nov 2021 13:00:31 GMT, Daniel Fuchs wrote: > Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-82

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v5]

2021-11-19 Thread Michael McMahon
On Fri, 19 Nov 2021 10:12:15 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v4]

2021-11-19 Thread Daniel Fuchs
On Fri, 19 Nov 2021 02:44:52 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v5]

2021-11-19 Thread Daniel Fuchs
> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take preceden