Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v4]

2021-11-18 Thread Jaikiran Pai
On Thu, 18 Nov 2021 19:49:19 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse

RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-18 Thread Brent Christian
Here are the code changes for the "Deprecate finalizers in the standard Java API" portion of JEP 421 ("Deprecate Finalization for Removal") for code review. This change makes the indicated deprecations, and updates the API spec for JEP 421. It also updates the relevant @SuppressWarning annotatio

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v3]

2021-11-18 Thread Daniel Fuchs
On Thu, 18 Nov 2021 12:04:01 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More cleanup > > src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java line > 124: > >> 122:

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v4]

2021-11-18 Thread Daniel Fuchs
> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take preceden

RFR: 8277412: Use String.isBlank to simplify code in sun.net.www.protocol.mailto.Handler

2021-11-18 Thread Andrey Turbanov
All this manually written code actually can be replaced with single String.isBlank() call. `file` variable is guaranteed to be non-null. - Commit messages: - [PATCH] Use String.isBlank to simplify code Changes: https://git.openjdk.java.net/jdk/pull/6372/files Webrev: https://webre

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v3]

2021-11-18 Thread Michael McMahon
On Wed, 17 Nov 2021 14:07:09 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse