Re: RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Chris Hegarty
On Wed, 9 Dec 2020 18:50:50 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a changeset that fixes the infrequent (but annoying) test >> failures >> caused by unexpected ConnectionException "Connection timed out: no further >> information" >> which have been observed to occur on some p

Re: RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Daniel Fuchs
On Wed, 9 Dec 2020 17:23:19 GMT, Chris Hegarty wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8256459: java/net/httpclient/ManyRequests.java and >> java/net/httpclient/LineBodyHandlerTest.java fail infrequently w

Re: RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Daniel Fuchs
> Hi, > > Please find here a changeset that fixes the infrequent (but annoying) test > failures > caused by unexpected ConnectionException "Connection timed out: no further > information" > which have been observed to occur on some platforms. > > Tests are updated to allow the test server to h

Re: icmp and raw sockets on linux

2020-12-09 Thread Jamie Le Tual
I'm wondering what the process is for the pull request I submitted, I guess I need a reviewer or a sponsor? On Tue, 1 Dec 2020 at 14:08, Jamie Le Tual wrote: > Hi Alan, > I received an email this morning saying my OCA had been processed, but > that it would perhaps take a couple of hours before

Re: RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Daniel Fuchs
On Wed, 9 Dec 2020 17:23:19 GMT, Chris Hegarty wrote: >> Hi, >> >> Please find here a changeset that fixes the infrequent (but annoying) test >> failures >> caused by unexpected ConnectionException "Connection timed out: no further >> information" >> which have been observed to occur on some

Re: RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Chris Hegarty
On Wed, 9 Dec 2020 15:37:42 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a changeset that fixes the infrequent (but annoying) test > failures > caused by unexpected ConnectionException "Connection timed out: no further > information" > which have been observed to occur on some platform

Re: RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Chris Hegarty
On Wed, 9 Dec 2020 15:37:42 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a changeset that fixes the infrequent (but annoying) test > failures > caused by unexpected ConnectionException "Connection timed out: no further > information" > which have been observed to occur on some platform

Integrated: 8254996: make jdk.net.UnixDomainPrincipal a record class

2020-12-09 Thread Patrick Concannon
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. How

Re: RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class [v3]

2020-12-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. However, these methods and fields are > susceptible to trivial

RFR: 8256459: java/net/httpclient/ManyRequests.java and java/net/httpclient/LineBodyHandlerTest.java fail infrequently with java.net.ConnectException: Connection timed out: no further information

2020-12-09 Thread Daniel Fuchs
Hi, Please find here a changeset that fixes the infrequent (but annoying) test failures caused by unexpected ConnectionException "Connection timed out: no further information" which have been observed to occur on some platforms. Tests are updated to allow the test server to handle requests con

Re: RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class [v2]

2020-12-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. However, these methods and fields are > susceptible to trivial

Re: RFR: 8255583: Investigate creating a test to trigger the condition in KeepAliveStreamCleaner [v3]

2020-12-09 Thread Michael McMahon
On Mon, 7 Dec 2020 17:11:28 GMT, Conor Cleary wrote: >> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously >> seen to fail with an IllegalMonitorStateException. This failure was caused >> by the use of `wait()` in a non synchronized block. This failure was >> mitigated t

Re: RFR: 8255583: Investigate creating a test to trigger the condition in KeepAliveStreamCleaner [v3]

2020-12-09 Thread Chris Hegarty
On Mon, 7 Dec 2020 17:11:28 GMT, Conor Cleary wrote: >> The KeepAliveStreamCleaner in sun.net.ww.http package had been previously >> seen to fail with an IllegalMonitorStateException. This failure was caused >> by the use of `wait()` in a non synchronized block. This failure was >> mitigated t