I'm wondering what the process is for the pull request I submitted, I guess I need a reviewer or a sponsor?
On Tue, 1 Dec 2020 at 14:08, Jamie Le Tual <jamie.let...@gmail.com> wrote: > Hi Alan, > I received an email this morning saying my OCA had been processed, but > that it would perhaps take a couple of hours before a bot picks it up and I > show up on the OCA signatories page (no idea where that page is though). > > I have also updated the patch in my pull request to cover ipv6 as well. > > Test cases are forthcoming. > > > On Sun, 29 Nov 2020 at 11:35, Alan Bateman <alan.bate...@oracle.com> > wrote: > >> On 29/11/2020 14:54, Jamie Le Tual wrote: >> >> Although I've only just sent in the pdf form for an ora, I've already >> submitted a pull request, https://github.com/openjdk/jdk/pull/1502 >> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/1502__;!!GqivPVa7Brio!JhGUqeElAhEy9M_c0xBiYFVZQXX0YeHTlOrypbtjph_VrhY7t4LmgPpmxNpSAwLCuA$> >> wherein an attempt is first made to use an IPPROTO_ICMP socket before >> falling back on RAW_SOCK and finally tcp echo. >> >> I suppose now I have to wait until I am able to open an issue in the bug >> tracker so I can associate the pull request to it. >> >> Does anyone know what a unit test for this might look like? To cover the >> use cases the code has to be invoked by both a privileged and unprivileged >> user, and I'm not sure how to go about setting up a unit test. >> >> >> I've created JDK-8257235 [1] to track this. One thing to understand is >> whether there is an equivalent for IPPROTO_ICMPV6. Sorry, I can't look at >> the patch or comment in the PR until the bot confirms that you have signed >> the OCA. >> >> Have you looked at the existing tests in test/jdk/java/net/InetAddress? >> It will be awkward to verify as the behaviour before/after will not be >> observable without looking at the network or system call trace. >> >> -Alan >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8257235 >> >
