Re: RFR: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonit… [v2]

2020-10-21 Thread Daniel Fuchs
On Wed, 21 Oct 2020 16:45:27 GMT, Jan Lahoda wrote: >> …orStateException: current thread is not owner >> >> The KeepAliveStreamCleaner is calling Condition.wait (i.e. the Object.wait >> variant), should presumably be calling Condition.await. (NetBeans is >> producing warnings on the line as we

Re: RFR: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonit… [v2]

2020-10-21 Thread Chris Hegarty
On Wed, 21 Oct 2020 16:45:27 GMT, Jan Lahoda wrote: >> …orStateException: current thread is not owner >> >> The KeepAliveStreamCleaner is calling Condition.wait (i.e. the Object.wait >> variant), should presumably be calling Condition.await. (NetBeans is >> producing warnings on the line as we

Re: RFR: 8245194: Unix domain socket channel implementation [v34]

2020-10-21 Thread Chris Hegarty
On Wed, 21 Oct 2020 16:31:06 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonit… [v2]

2020-10-21 Thread Alan Bateman
On Wed, 21 Oct 2020 16:42:39 GMT, Jan Lahoda wrote: >> …orStateException: current thread is not owner >> >> The KeepAliveStreamCleaner is calling Condition.wait (i.e. the Object.wait >> variant), should presumably be calling Condition.await. (NetBeans is >> producing warnings on the line as we

Re: RFR: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonit… [v2]

2020-10-21 Thread Jan Lahoda
> …orStateException: current thread is not owner > > The KeepAliveStreamCleaner is calling Condition.wait (i.e. the Object.wait > variant), should presumably be calling Condition.await. (NetBeans is > producing warnings on the line as well.) Jan Lahoda has updated the pull request incrementally

Re: RFR: 8245194: Unix domain socket channel implementation [v34]

2020-10-21 Thread Chris Hegarty
On Wed, 21 Oct 2020 16:31:06 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8245194: Unix domain socket channel implementation [v34]

2020-10-21 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more iterations before integrating. > > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to us

Re: RFR: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonit…

2020-10-21 Thread Alan Bateman
On Wed, 21 Oct 2020 13:12:03 GMT, Jan Lahoda wrote: > …orStateException: current thread is not owner > > The KeepAliveStreamCleaner is calling Condition.wait (i.e. the Object.wait > variant), should presumably be calling Condition.await. (NetBeans is > producing warnings on the line as well.)

RFR: 8255124: KeepAliveStreamCleaner may crash with java.lang.IllegalMonit…

2020-10-21 Thread Jan Lahoda
…orStateException: current thread is not owner The KeepAliveStreamCleaner is calling Condition.wait (i.e. the Object.wait variant), should presumably be calling Condition.await. (NetBeans is producing warnings on the line as well.) - Commit messages: - Adding bug number to the tes

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-21 Thread Michael McMahon
On Wed, 21 Oct 2020 09:20:47 GMT, Chris Hegarty wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> further test update from Daniel > > test/jdk/java/net/UnixDomainSocketAddress/LengthTest.java line 55: > >> 53:

Re: RFR: 8245194: Unix domain socket channel implementation [v33]

2020-10-21 Thread Daniel Fuchs
On Wed, 21 Oct 2020 10:22:11 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa

Re: RFR: 8245194: Unix domain socket channel implementation [v33]

2020-10-21 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more iterations before integrating. > > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to us

Integrated: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer

2020-10-21 Thread Patrick Concannon
On Mon, 12 Oct 2020 13:37:04 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean > up in HttpsExchange, HttpsParameters, and HttpsServer' ? > > This fix is set of formatting changes intended to clean up the javadoc of the > foll

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-21 Thread Chris Hegarty
On Tue, 20 Oct 2020 14:21:42 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more iterations before >> integrating. >> >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMa