RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format

2020-10-20 Thread Igor Ignatyev
Hi all, could you please review this small patch? according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in MLSx response have the following format: >time-val = 14DIGIT [ "." 1*DIGIT ] > >The leading, mandatory, fourteen digits are to be interpreted as, in >order f

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-20 Thread Daniel Fuchs
On Tue, 20 Oct 2020 14:21:42 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v32]

2020-10-20 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v31]

2020-10-20 Thread Michael McMahon
On Tue, 20 Oct 2020 13:59:23 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> forgot to stage updated test files in last commit > > test/jdk/java/net/UnixDomainSocketAddress/AddressTest.java lin

Re: RFR: 8245194: Unix domain socket channel implementation [v31]

2020-10-20 Thread Daniel Fuchs
On Tue, 20 Oct 2020 13:52:41 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v31]

2020-10-20 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v30]

2020-10-20 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Michael McMahon
On Tue, 20 Oct 2020 10:36:24 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> final feedback from Alan > > test/jdk/java/nio/channels/unixdomain/SocketOptions.java line 59: > >> 57: s.b

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Michael McMahon
On Tue, 20 Oct 2020 10:28:13 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> final feedback from Alan > > test/jdk/java/nio/channels/unixdomain/NonBlockingAccept.java line 61: > >> 59:

Re: RFR: 8245194: Unix domain socket channel implementation [v29]

2020-10-20 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Daniel Fuchs
On Mon, 19 Oct 2020 22:13:40 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer [v7]

2020-10-20 Thread Patrick Concannon
> Hi, > > Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean > up in HttpsExchange, HttpsParameters, and > HttpsServer' ? > This fix is set of formatting changes intended to clean up the javadoc of the > following classes : > > `com.sun.net.httpserver.HttpsExchange` > `

Re: RFR: 8245194: Unix domain socket channel implementation [v28]

2020-10-20 Thread Alan Bateman
On Mon, 19 Oct 2020 22:13:40 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w