Hi Christoph,
Looks good to me 😊
Best regards,
Goetz.
-Original Message-
From: nio-dev On Behalf Of Christoph Langer
Sent: Montag, 7. September 2020 06:22
To: hotspot-...@openjdk.java.net; net-dev@openjdk.java.net;
nio-...@openjdk.java.net; serviceability-...@openjdk.java.net
Subjec
The format for SAP copyrights in OpenJDK headers should be like:
Copyright (c) SAP SE. All rights reserved.
or
Copyright (c) , SAP SE. All rights reserved.
There should not be a comma character (",") before "SAP SE".
This is inconsistent in some files which calls for some cleanup.
Please revie
> On Sep 6, 2020, at 9:51 PM, Kim Barrett wrote:
> Oh, good grief! This file contains 3 identical copies of getMTU and
> getFlags, one each for linux, AIX, and BSD. And getIndex is kind of a
> mess. If changing any of these for linux, probably similar changes
> ought to be applied to the other
> On Sep 6, 2020, at 1:03 PM, Florian Weimer wrote:
> There is no reason to use strncpy. At least on Linux, the struct field
> needs to be null-terminated, and you need to compute the length for the
> length check. So you might as well use memcpy with the length plus one
> (to copy the null term
> On Sep 6, 2020, at 7:35 AM, Kim Barrett wrote:
> src/java.base/unix/native/libnet/NetworkInterface.c
> 1298 memset((char *)&if2, 0, sizeof(if2));
> 1299 strncpy(if2.ifr_name, name, sizeof(if2.ifr_name) - 1);
> 1300 if2.ifr_name[sizeof(if2.ifr_name) - 1] = 0;
>
> (in getIndex)
>
> S
> On Sep 6, 2020, at 7:35 AM, Kim Barrett wrote:
> src/hotspot/share/compiler/compileBroker.hpp
> 64 PRAGMA_DIAG_PUSH
> 65 PRAGMA_STRINGOP_TRUNCATION_IGNORED
> 66 // This code can incorrectly cause a "stringop-truncation" warning
> with gcc
> 67 strncpy(_current_method, method, (size_
* Kim Barrett:
>> On Sep 4, 2020, at 7:50 AM, Florian Weimer wrote:
>>
>> * Daniel Fuchs:
>>
>>> Hi,
>>>
>>> On 02/09/2020 08:19, Florian Weimer wrote:
At least one of the bugs was in theory user-visible: the network
interface code would return data for an interface that does not act
> On Sep 1, 2020, at 9:59 AM, Eric Liu wrote:
> I just tested this patch by GCC (10.1.0) and it would really re-trigger those
> warnings :(
> I have not noticed the history before, but it's really hard to imagine that
> GCC would
> have different behaviors.
Can you be (very) specific about thi
> On Sep 4, 2020, at 7:50 AM, Florian Weimer wrote:
>
> * Daniel Fuchs:
>
>> Hi,
>>
>> On 02/09/2020 08:19, Florian Weimer wrote:
>>> At least one of the bugs was in theory user-visible: the network
>>> interface code would return data for an interface that does not actually
>>> exist on the sy
On Sun, 6 Sep 2020 10:56:44 GMT, Alan Bateman wrote:
> The URL creation isn't technically right as you can't reliably use a file
> path string as a URL path. Something like the
> following would be more correct:
URL url = Path.of(System.getProperty("java.io.tmpdir")).toUri().toURL();
I've now u
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Sun, 6 Sep 2020 09:38:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Sun, 6 Sep 2020 09:11:52 GMT, Jaikiran Pai wrote:
>> test/jdk/sun/net/www/URLConnectionTest.java line 36:
>>
>>> 34: * @run testng URLConnectionTest
>>> 35: */
>>> 36: public class URLConnectionTest {
>>
>> I think it would be better to put the test in
>> test/jdk/java/net/URLConnection a
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError` instead
> of a `IllegalStateException`. The commit her
On Sun, 6 Sep 2020 09:05:55 GMT, Alan Bateman wrote:
>> Can I please get a review and a sponsor for a fix for the issue reported at
>> https://bugs.openjdk.java.net/browse/JDK-8252767?
>> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty`
>> is throwing a `IllegalAccessEr
On Sun, 6 Sep 2020 05:46:42 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError`
Can I please get a review and a sponsor for a fix for the issue reported at
https://bugs.openjdk.java.net/browse/JDK-8252767?
As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
throwing a `IllegalAccessError` instead
of a `IllegalStateException`. The commit here fixes t
On Sun, 6 Sep 2020 05:46:42 GMT, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for a fix for the issue reported at
> https://bugs.openjdk.java.net/browse/JDK-8252767?
> As noted in that issue, the `sun.net.www.URLConnection#setRequestProperty` is
> throwing a `IllegalAccessError`
18 matches
Mail list logo
