Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-18 Thread Alan Bateman
On 18/07/2020 18:43, Bernd Eckenfels wrote: Hello, I am unsure about the signatures, s is of type SOCKET, why not keep this — I think I missed why this would be a JNICALL convention. There are two inconsistencies: The header file and implementation uses (int) argument, the call casts to (ji

Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-18 Thread Bernd Eckenfels
Hello, I am unsure about the signatures, s is of type SOCKET, why not keep this — I think I missed why this would be a JNICALL convention. There are two inconsistencies: The header file and implementation uses (int) argument, the call casts to (jint). And I also think it's not a big problem t

Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter

2020-07-18 Thread Alan Bateman
On 17/07/2020 02:10, Nikola Grcevski wrote: Thanks for reviewing the patch Alan. I applied your suggestions in this new webrev here: http://cr.openjdk.java.net/~adityam/nikola/fast_connect_loopback_1/ I renamed the macro to IN6_IS_ADDR_MAPPED_IP4_LOOPBACK, following how IN6_IS_ADDR_ANY is nam