On 18/07/2020 18:43, Bernd Eckenfels wrote:
Hello,
I am unsure about the signatures, s is of type SOCKET, why not keep
this — I think I missed why this would be a JNICALL convention.
There are two inconsistencies:
The header file and implementation uses (int) argument, the call casts
to (jint).
The networking support functions are in net.dll. The use-site for the
current patch is nio.dll.
Yes, are a few inconsistent int/jint issues with the NET_* functions
that libnet/net exports. Not a big concern unless you spot any cases
where the function prototype doesn't match the function. For now, the
single usage of NET_EnableFastTcpLoopbackConnect does not check the
status. Once the legacy PSI and PSDI implementations go away then there
will be a lot of opportunity to clean up some of this code. It might be
that the some of the supporting functions go away completely, maybe some
will move into libnio.
-Alan.
