Hello Nikola,
Can you explain why timeouts play a role here at all? Normally when connecting
to a non existing socket it should immediately respond with a TCP RST and that
should not cause a retry or delay.
Reducing the timeouts seems oddly specific, especially since your test numbers
show, th
Hello net-dev,
During a recent performance investigation of Gradle/Kotlin build daemon
discovery, we found that Windows socket connect on a non-existent service is
taking a lot longer than on Linux and MacOS. The socket timeout and retransmit
defaults on Windows are quite long and it typically
Hi Daniel,
you are right, Alan is talking the same , in webrev that i have posted code
is not properly formatted.
In my local repo code is properly formatted.
Thanks,
Vyom
On Wed, Jul 15, 2020 at 2:55 PM Daniel Fuchs
wrote:
> Hi Vyom,
>
> I don't know if that's what Alan is referring to but I
Hi Vyom,
I don't know if that's what Alan is referring to but I see
this:
bsd_close.c:
missing space just after `if` extra space just before `timeout`:
475 if( timeout > 0) {
linux_close.c:
missing space just after `if`:
440 if(timeout > 0) {
missing space just afte
Hi Alan,
thanks for the review, I will definitely fix any formatting issue before
pushing the patch. My local repo code is properly formatted and i was
suspecting that webrev is ignoring the space while generating the patch
file that's why you are seeing the formatting issue.
My local code is p
On 14/07/2020 20:09, Daniel Fuchs wrote:
On 12/07/2020 07:36, Vyom Tiwari wrote:
Hi Patrick,
Thanks for testing, Alan, Daniel can i get the final review comment
from you both ?.
Hi Vyom,
http://cr.openjdk.java.net/~vtewari/8237858/webrev1.0/index.html
Vyom - will you fix the formattin
