Hi Alan, thanks for the review, I will definitely fix any formatting issue before pushing the patch. My local repo code is properly formatted and i was suspecting that webrev is ignoring the space while generating the patch file that's why you are seeing the formatting issue.
My local code is properly formatted and i am assuming that while pushing there will not be any formatting issue. Please let me know if I am missing something. thanks, Vyom On Wed, Jul 15, 2020 at 12:44 AM Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 14/07/2020 20:09, Daniel Fuchs wrote: > > On 12/07/2020 07:36, Vyom Tiwari wrote: > >> Hi Patrick, > >> > >> Thanks for testing, Alan, Daniel can i get the final review comment > >> from you both ?. > >> > > > > Hi Vyom, > > > > http://cr.openjdk.java.net/~vtewari/8237858/webrev1.0/index.html > Vyom - will you fix the formatting issues in linux_close.c and > bsd_close.c before you push this? You mentioned that it's a webrev issue > but I don't think so because they are in the patch file too. > > -Alan > -- Thanks, Vyom
