Thank you Alan
-Aleksei
On 26/05/2020 13:50, Alan Bateman wrote:
On 26/05/2020 11:22, Aleks Efimov wrote:
Hi Alan,
Thank you for the review. I've renamed 'appendAddresses' to
'concatAddresses' per your suggestion.
And also removed 'arrangeAddresses' method and moved its code to
'lookupAll
On 26/05/2020 11:22, Aleks Efimov wrote:
Hi Alan,
Thank you for the review. I've renamed 'appendAddresses' to
'concatAddresses' per your suggestion.
And also removed 'arrangeAddresses' method and moved its code to
'lookupAllHostAddr'.
Webrev with new version can be viewed here:
http://cr.op
Thank you, Daniel! Changed it to 'isEmpty'.
-Aleksei
On 26/05/2020 12:39, Daniel Fuchs wrote:
Hi Aleksei,
Still looks good to me.
One detail that jumped at me however:
1079 if (res.size() == 0) {
should probably be changed to `if (res.isEmpty()) {`
No need for a new webrev.
bes
Hi Aleksei,
Still looks good to me.
One detail that jumped at me however:
1079 if (res.size() == 0) {
should probably be changed to `if (res.isEmpty()) {`
No need for a new webrev.
best regards,
-- daniel
On 26/05/2020 11:22, Aleks Efimov wrote:
Hi Alan,
Thank you for the revi
Hi Alan,
Thank you for the review. I've renamed 'appendAddresses' to
'concatAddresses' per your suggestion.
And also removed 'arrangeAddresses' method and moved its code to
'lookupAllHostAddr'.
Webrev with new version can be viewed here:
http://cr.openjdk.java.net/~aefimov/8244958/02
-Aleks
Hi Aleksei,
The new webrev looks good to me.
best regards,
-- daniel
On 25/05/2020 17:49, Aleks Efimov wrote:
Hi Vyom,
Thanks for reviewing it. I'm ok with stepping aside of general naming
convention to maintain the compatibility with the naming in InetAddress
code:
InetAddress.HostsFi
On 25/05/2020 11:47, Aleks Efimov wrote:
Hi Alan, Daniel,
Thank you for looking into this change. I've cleaned-up the fix and
the test according to your comments.
Modified fix can be viewed here:
http://cr.openjdk.java.net/~aefimov/8244958/01
Thanks for the update, I think this version look
Vladimir,
I think we should create some documentation for this socket option.
In JDK-8243099 you mention tests done with Apache Kafka so I assume that
somebody has already modified Kafka to use this feature and maybe it
would useful to document what was done and use that as a basis for
someth
