RE: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-11 Thread Ivanov, Vladimir A
Thanks a lot Patrick. Your tests looks better then proposed ones. Updated webrev available as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.12 Thanks, Vladimir -Original Message- From: Patrick Concannon Sent: Monday, May 11, 2020 11:11 AM To: Ivanov, Vladimir A ; Al

Re: 8235761: (httpclient) Investigate support for multipart/form-data in BodyPublishers

2020-05-11 Thread Moataz Abdelnasser
Email was unintentionally sent in HTML, causing it to be scrubbed. This is plain text form: Hi all! I tackled with the multipart issue in a library I wrote that provides extensions to the HTTP client including multipart support (please see https://github.com/mizosoft/methanol). I was wondering if

8235761: (httpclient) Investigate support for multipart/form-data in BodyPublishers

2020-05-11 Thread Moataz Abdelnasser
Hi all! I tackled with the multipart issue in a library I wrote that provides extensions to the HTTP client including multipart support (please see https://github.com/mizosoft/methanol).I was wondering if I could provide a patch for this issue in the light of  MultipartBodyPublisher.java to be incl

Re: RFR 15 8243099: SO_INCOMING_NAPI_ID support

2020-05-11 Thread Patrick Concannon
Hi Vladamir, Just a few observations with your test, ExtOptionNAPITest: I don't think the static class TestThread is needed for what you're trying to check and I think you can remove it. Also, I think using testNG assertions rather than throwing RunTimeExceptions might be better here, for exam

Re: [8u] RFR(XS): 8244461: [JDK 8u] Build fails with glibc 2.32

2020-05-11 Thread Andrew Hughes
On 08/05/2020 09:07, Severin Gehwolf wrote: > Hi, > > Please review this OpenJDK 8u (and 7u) specific patch which fixes a > build failure with > upcoming glibc 2.32 release. This isn't an issue in later JDKs because > headers got cleaned > up by JDK-8167481. Bringing this back into OpenJDK 8u to

Re: RFC: 8132359: JarURLConnection.getJarFile() resource leak when file is not found

2020-05-11 Thread Michael McMahon
On 10/05/2020 21:51, Alex Kashchenko wrote: Thanks for your comments! On 05/08/2020 06:38 PM, Michael McMahon wrote: [...] https://bugs.openjdk.java.net/browse/JDK-8244650 I believe some sort of spec change will be needed, if only to justify challenging the JCK. Currently, the proposed c